-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bug 1810019 [wpt PR 37916] - Revert "[view-timeline]: Update naming f…
…or delay as timeline offset", a=testonly Automatic update from web-platform-tests Revert "[view-timeline]: Update naming for delay as timeline offset" This reverts commit 8c67ecf3a1d46af987a2097bfa685fdc00937b43. Reason for revert: LUCI Bisection identified this CL as the culprit of a build failure. See the analysis: https://luci-bisection.appspot.com/analysis/b/8792142657514411521 Sample failed build: https://ci.chromium.org/b/8792142657514411521 If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fluci-bisection.appspot.com%2Fanalysis%2Fb%2F8792142657514411521&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4081107 Original change's description: > [view-timeline]: Update naming for delay as timeline offset > > Patch implements rename based on most recent recommendation in > w3c/csswg-drafts#7589. > > Next steps: > * CSS support for animation-range. > * Support for % delays. > * Support for range(Start|End) as string in animation effect timing options. > * Removal of <name> <percent> from animation-delay. > * Support range(Start|End) as CSSNumericValue (offset only with implied 'cover' as named range). > > Bug: 1383162 > Change-Id: I9d2e9572aac31c79fb937514c1f65e6940a9e27e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4081107 > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Commit-Queue: Kevin Ellis <kevers@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1092031} > Bug: 1383162 Change-Id: Id7c8f3ca84675b454d14a18a45aa1895c87d303f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4162958 Commit-Queue: Jonathan Njeunje <njeunje@chromium.org> Reviewed-by: Jonathan Njeunje <njeunje@chromium.org> Owners-Override: Jonathan Njeunje <njeunje@chromium.org> Cr-Commit-Position: refs/heads/main@{#1092052} -- wpt-commits: 3103e5894fcb303d2ea34bc918fdd014cb3f78e5 wpt-pr: 37916
- Loading branch information
1 parent
5111803
commit 2cb9288
Showing
10 changed files
with
387 additions
and
201 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
144 changes: 144 additions & 0 deletions
144
testing/web-platform/tests/scroll-animations/css/view-timeline-delay-animation.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,144 @@ | ||
| <!DOCTYPE html> | ||
| <title>Animations using named timeline ranges</title> | ||
| <link rel="help" src="https://drafts.csswg.org/scroll-animations-1/#named-timeline-range"> | ||
| <script src="/resources/testharness.js"></script> | ||
| <script src="/resources/testharnessreport.js"></script> | ||
| <script src="/web-animations/testcommon.js"></script> | ||
| <script src="support/testcommon.js"></script> | ||
| <style> | ||
| @keyframes anim { | ||
| from { z-index: 0; background-color: skyblue;} | ||
| to { z-index: 100; background-color: coral; } | ||
| } | ||
| #scroller { | ||
| border: 10px solid lightgray; | ||
| overflow-y: scroll; | ||
| width: 200px; | ||
| height: 200px; | ||
| } | ||
| #target { | ||
| margin: 800px 0px; | ||
| width: 100px; | ||
| height: 100px; | ||
| z-index: -1; | ||
| background-color: green; | ||
| } | ||
| </style> | ||
| <main id=main> | ||
| </main> | ||
| <template> | ||
| <div id=scroller> | ||
| <div id=target></div> | ||
| </div> | ||
| </template> | ||
| <script> | ||
| setup(assert_implements_animation_timeline); | ||
|
|
||
| function inflate(t, template) { | ||
| t.add_cleanup(() => main.replaceChildren()); | ||
| main.append(template.content.cloneNode(true)); | ||
| } | ||
| async function scrollTop(e, value) { | ||
| e.scrollTop = value; | ||
| await waitForNextFrame(); | ||
| } | ||
| async function waitForAnimationReady(target) { | ||
| await waitForNextFrame(); | ||
| await Promise.all(target.getAnimations().map(x => x.promise)); | ||
| } | ||
| async function assertValueAt(scroller, target, args) { | ||
| await waitForAnimationReady(target); | ||
| await scrollTop(scroller, args.scrollTop); | ||
| assert_equals(getComputedStyle(target).zIndex, args.expected.toString()); | ||
| } | ||
| function test_animation_delay(options) { | ||
| promise_test(async (t) => { | ||
| inflate(t, document.querySelector('template')); | ||
| let scroller = main.querySelector('#scroller'); | ||
| let target = main.querySelector('#target'); | ||
|
|
||
| target.style.viewTimeline = 't1 block'; | ||
| // TODO(crbug.com/1375998): Create the timeline in a separate frame to | ||
| // work around a bug. | ||
| await waitForNextFrame(); | ||
|
|
||
| target.style.animation = 'anim 10s linear'; | ||
| target.style.animationTimeline = 't1'; | ||
| target.style.animationDelayStart = options.startDelay; | ||
| target.style.animationDelayEnd = options.endDelay; | ||
|
|
||
| // Accommodates floating point precision errors at the endpoints. | ||
| target.style.animationFillMode = 'both'; | ||
|
|
||
| // 0% | ||
| await assertValueAt(scroller, target, | ||
| { scrollTop: options.rangeStart, expected: 0 }); | ||
| // 50% | ||
| await assertValueAt(scroller, target, | ||
| { scrollTop: (options.rangeStart + options.rangeEnd) / 2, expected: 50 }); | ||
| // 100% | ||
| await assertValueAt(scroller, target, | ||
| { scrollTop: options.rangeEnd, expected: 100 }); | ||
|
|
||
| // Test before/after phases (need to clear the fill mode for that). | ||
| target.style.animationFillMode = 'initial'; | ||
| await assertValueAt(scroller, target, | ||
| { scrollTop: options.rangeStart - 10, expected: -1 }); | ||
| await assertValueAt(scroller, target, | ||
| { scrollTop: options.rangeEnd + 10, expected: -1 }); | ||
| // Check 50% again without fill mode. | ||
| await assertValueAt(scroller, target, | ||
| { scrollTop: (options.rangeStart + options.rangeEnd) / 2, expected: 50 }); | ||
|
|
||
| }, `Animation with delays [${options.startDelay}, ${options.endDelay}]`); | ||
| } | ||
|
|
||
| test_animation_delay({ | ||
| startDelay: 'initial', | ||
| endDelay: 'initial', | ||
| rangeStart: 600, | ||
| rangeEnd: 900 | ||
| }); | ||
|
|
||
| test_animation_delay({ | ||
| startDelay: 'cover 0%', | ||
| endDelay: 'cover 100%', | ||
| rangeStart: 600, | ||
| rangeEnd: 900 | ||
| }); | ||
|
|
||
| test_animation_delay({ | ||
| startDelay: 'contain 0%', | ||
| endDelay: 'contain 100%', | ||
| rangeStart: 700, | ||
| rangeEnd: 800 | ||
| }); | ||
|
|
||
| test_animation_delay({ | ||
| startDelay: 'enter 0%', | ||
| endDelay: 'enter 100%', | ||
| rangeStart: 600, | ||
| rangeEnd: 700 | ||
| }); | ||
|
|
||
| test_animation_delay({ | ||
| startDelay: 'exit 0%', | ||
| endDelay: 'exit 100%', | ||
| rangeStart: 800, | ||
| rangeEnd: 900 | ||
| }); | ||
|
|
||
| test_animation_delay({ | ||
| startDelay: 'contain -50%', | ||
| endDelay: 'enter 200%', | ||
| rangeStart: 650, | ||
| rangeEnd: 800 | ||
| }); | ||
|
|
||
| test_animation_delay({ | ||
| startDelay: 'enter 0%', | ||
| endDelay: 'exit 100%', | ||
| rangeStart: 600, | ||
| rangeEnd: 900 | ||
| }); | ||
| </script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.