Skip to content

Commit

Permalink
Bug 1867730 [wpt PR 43465] - Revert "Dispatch close event when Messag…
Browse files Browse the repository at this point in the history
…ePort is disentangled", a=testonly

Automatic update from web-platform-tests
Revert "Dispatch close event when MessagePort is disentangled"

This reverts commit 6a74d3d8049e1744b862757a73f90f3d7a5e08b0.

Reason for revert:
The tests newly added by the original CL are failing on
chrome_wpt_tests on the Linux Tests bot:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/138259/overview

Original change's description:
> Dispatch close event when MessagePort is disentangled
>
> We want to dispatch a close event when an entangled MessagePort is disconnected.
> Given a pair of entangled ports, port1 and port2, if port2 is closed at any point,
> a port1’s error handler is run.
> So we can change an error handler to dispatch a close event.
>
> The tests of close event are as follows:
> 1) port was explicitly closed.
> 2) owning document was destroyed.
> 3) owning document crashed.
> 4) port was garbage collected.
>
> Design Doc:https://docs.google.com/document/d/1lXZU2Pk2ycitqj8aL9kxT2aauwXqpA0vJDUalkXA29Y
> Explainer:https://github.com/fergald/explainer-messageport-close
> HTML spec PR:whatwg/html#9933
>
> Bug: 1495616
> Change-Id: I99f9f5a0d7cc63f0916da316ec666ba793215019
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5003089
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Commit-Queue: Nonoka Muraki <murakinonoka@chromium.org>
> Reviewed-by: Ming-Ying Chung <mych@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1231743}

Bug: 1495616
Change-Id: Ib697597d6ab70a9a7bfc41a67dfc647698024a64
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5075742
Reviewed-by: Ming-Ying Chung <mych@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Owners-Override: Hiroki Nakagawa <nhiroki@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1231780}

--

wpt-commits: 5d1c45f9f81c37c45e7acc351348cd6e9879597f
wpt-pr: 43465
  • Loading branch information
nhiroki authored and moz-wptsync-bot committed Dec 4, 2023
1 parent 5a1b89a commit 67ee21c
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 242 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,6 @@ self.addEventListener('message', function(event) {
client.postMessage("dummyValue");
}
event.data.port.postMessage("PASS");
} else if (event.data.type == 'storeMessagePort') {
let isCloseEventFired = false;
const port = event.ports[0];
port.start();
port.onmessage = (event) => {
if (event.data == 'Confirm the ports can communicate') {
port.postMessage('Receive message');
} else if (event.data == 'Ask if the close event was fired') {
port.postMessage(isCloseEventFired);
}
};
port.onclose = () => {
isCloseEventFired = true;
};
}
});

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// META: title=close event test

async_test(t => {
const channel = new MessageChannel();
channel.port1.start();
channel.port1.onclose = t.step_func_done();
channel.port1.dispatchEvent(new Event('close'));
}, 'Close event listener added with onclose must be called.');

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

0 comments on commit 67ee21c

Please sign in to comment.