Corner case for fragments

[petterek]

    Dim s As String = "a < b"
    Dim cs = CsQuery.CQ.Create(s)
    Assert.AreEqual("a &lt; b", cs.Render())

Do not work..

cs.Render returns "a "

[jamietre]

Sure enough. I think the parser doesn't reject a carat followed by whitespace properly.

This text

"a<b"

should actually be parsed as just "a" (at least, that is how chrome handles it - rejecting the unclosed tag). With spaces, though, the caret should be treated as text. Will get this fixed.

[petterek]

Superb..

As you say only < followed by a-z should be treated as a tag.
Perhaps it's possible to implement some kind of "sliding caret" logic so.. can only have 1 open tag active at any time.
Then

"a<b" returns "a&lt;b" because there is no end >.. 

and

"a<<b" returns "a&lt;&lt;b"

Could be rather hard to implement?

[jamietre]

I don't think it would be hard to treat an unclosed caret as text, but I'm going for consistency with the HTML5 spec.
Since the actual spec is, sometimes, extraordinarily complicated, sometimes I just see how Chrome parses edge cases instead of being sure I understand the exact handling according to the spec :)

Chrome could also be doing it wrong, though, but it seems like as good a model as any to the extent that I don't have the time to fully delve into the low level details of the spec...

[petterek]

:)

[jamietre]

This got me thinking a bit... just to make sure chrome handles things the same for parsing a whole document vs. a fragment

var div= document.createElement('div');
div.innerHTML='a<b';
console.log(div.innerHTML);
==> a

it does indeed toss the unclosed tag when parsing HTML fragments.

[petterek]

hmmm
Then I belive your strategy "do as Chrome does" is a good one..

I am using CSQuery to sanitize input from users. And as you might know, user are capeable of doing all the wrong things.. :)
I thought I upload it to Github when it's in production, with a link back to CSQuery..
Keep up the good work ..

[jamietre]

Sanitizing input where you want to allow some valid HTML and also allow people to just enter text is definitely a little tricky!

The HTML parser does have a couple internal settings for different ways to handle broken tags. It might be not that hard to pass through unclosed tags as a special parsing option, I'll take a look when I'm looking at this later.

[petterek]

Superb :) !

[jamietre]

Pushed out a change that should deal with this. If you want to try it out, pull the update or grab the DLLs from the "distribution" folder.

I still haven't decided what to do about the rendering options from your last issue -- and no major bugs have come up since the last release. So I'm not in a hurry to push this out NuGet.

[petterek]

That is ok. I will give it a go.

[petterek]

    Dim s As String = "a < bsdf <>"
    Dim cs = CsQuery.CQ.Create(s)

    Assert.AreEqual("a &lt; bsdf &lt;&gt;", cs.Render()) <= OK
    Assert.AreEqual("a &lt; bsdf &lt;&gt;", cs.Render(CsQuery.DomRenderingOptions.HtmlEncodingMinimum)) <=FAILS

[jamietre]

Fixed in last push.

[petterek]

<Test> Sub UnwrapWithOutParentFails()
    Dim s As String = "This is <b> a big</b> text"
    Dim f = CsQuery.CQ.Create(s)

    Assert.DoesNotThrow(Sub() f("b").Unwrap().Render())
End Sub

Just another corner case.. probably not a bug...

[jamietre]

Bug - this is actually related to the one substantial change i had to make b/c of the new parser. Everything has a "Document" now, before, sometimes fragments did not before depending on how they were created. This is a correct model now but it looks like a piece of code is still testing for a missing parent. Will get this updated shortly.

[jamietre]

Fixed now.

[jamietre]

This fix is now on nuget (prerelease) as beta2 - closing.