Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong condition to create wss url in web_socket_transport.dart #1

Closed
ddcanh opened this issue Dec 25, 2019 · 0 comments
Closed

Wrong condition to create wss url in web_socket_transport.dart #1

ddcanh opened this issue Dec 25, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ddcanh
Copy link

ddcanh commented Dec 25, 2019

Hi guys, thanks for the lib. It works great on flutter web.
However, I think there is a bug in web_socket_transport.dart.
In line 32 you add access token to url by this condition:
url += (url.contains('?') ? '?' : '&') + "access_token=$encodedToken";
I need to fix this line to get it work:
url += (url.contains('?') ? '&' : '?') + "access_token=$encodedToken";
Please check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants