Replace type_cast_from_column to lookup_cast_type_from_column. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails 6.1 type_cast_from_column API has been removed: rails/rails#39106 lookup_cast_type_from_column was exists in Rails 5.0
mberlanda
reviewed
Feb 5, 2021
mberlanda
reviewed
Feb 11, 2021
Comment on lines
+83
to
+85
| @before_save_callback&.call(@set) | ||
| execute_query | ||
| @after_save_callback.() if @after_save_callback | ||
| @after_save_callback&.call |
There was a problem hiding this comment.
this would break the compatibility with ruby 2.2
Comment on lines
+110
to
+113
| if column | ||
| # https://github.com/rails/rails/commit/cfa5aa7977c4c3c8e318df196d4dea54fb6b8802 | ||
| type = @connection.lookup_cast_type_from_column(column) | ||
| value = type.serialize(value) |
There was a problem hiding this comment.
this seems to have been covered by #64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 6.1
type_cast_from_columnAPI has been removed:rails/rails#39106
lookup_cast_type_from_columnwas exists in Rails 5.0