Replace 'type_cast_from_column' to support Rails 6.1 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mberlanda Does this seem like a reasonable change? I'm trying to upgrade a project to Rails 6.1 and it would be really helpful if we could release 1.8.2 with this change |
|
This patch works great on Rails 6.1.1. |
mberlanda
reviewed
Feb 3, 2021
| value = @connection.type_cast_from_column(column, value) if column | ||
| if column | ||
| type = @connection.lookup_cast_type_from_column(column) | ||
| value = type.serialize(value) |
There was a problem hiding this comment.
Can we confirm that this addition is backward compatible with Rails versions between 5 and 6.1?
There was a problem hiding this comment.
I run some tests locally and it seems to work.
mberlanda
approved these changes
Feb 5, 2021
| value = @connection.type_cast_from_column(column, value) if column | ||
| if column | ||
| type = @connection.lookup_cast_type_from_column(column) | ||
| value = type.serialize(value) |
There was a problem hiding this comment.
I run some tests locally and it seems to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a column to the active_record method
type_castis deprecated and will be removed in Rails 6.2. Thetype_cast_from_columnmethod was also removed as part of Rails 6.1 in this PR. In the short term we can manually calllookup_cast_type_from_columnand serialize our values with the returned type.This resolves errors that look like the following, which occur when using
bulk_insertand active_record6.1.X, such as #67: