Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies for build & test not working in AudioGraph #187

Closed
nwolek opened this issue Nov 20, 2013 · 2 comments
Closed

Dependencies for build & test not working in AudioGraph #187

nwolek opened this issue Nov 20, 2013 · 2 comments
Assignees

Comments

@nwolek
Copy link
Member

nwolek commented Nov 20, 2013

see commit 43118d0

@ghost ghost assigned nwolek Nov 20, 2013
@nwolek
Copy link
Member Author

nwolek commented Nov 27, 2013

Other libraries are dependent on themselves & Foundation. This one is dependent on AudioGraph, Graph & Foundation. See the YAML file here:
https://github.com/jamoma/JamomaCore/blob/master/AudioGraph/library/JamomaAudioGraph.yml

The if statements I built into the jamomalib.rb script only include the "self" & Foundation as dependencies:
https://github.com/jamoma/JamomaCore/blob/dev/Shared/jamomalib.rb#L1718

Since these are hard coded into the script, when the dependencies change it will break the testing until the script gets updated too. I am thinking a better way to handle this would be to use the YAML information to reconfigure the dependencies for testing. That way when YAML is updated, it will generate a new makefile to properly test during build.

@tap
Copy link
Member

tap commented Nov 27, 2013

Agree! Great idea!

Other libraries are dependent on themselves & Foundation. This one is
dependent on AudioGraph, Graph & Foundation. See the YAML file here:

https://github.com/jamoma/JamomaCore/blob/master/AudioGraph/library/JamomaAudioGraph.yml

The if statements I built into the jamomalib.rb script only include the
"self" & Foundation as dependencies:
https://github.com/jamoma/JamomaCore/blob/dev/Shared/jamomalib.rb#L1718

Since these are hard coded into the script, when the dependencies change
it will break the testing until the script gets updated too. I am thinking
a better way to handle this would be to use the YAML information to
reconfigure the dependencies for testing. That way when YAML is updated, it
will generate a new makefile to properly test during build.


Reply to this email directly or view it on GitHubhttps://github.com//issues/187#issuecomment-29391740
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants