Widget for Galaxy Gear S2/3 watchface using Wearable Widgets #47

dwallersv · 2018-01-28T16:58:36Z

Implemented a second widget for use with the Wearable Widgets application to display BG information and trend graph with prominent time/date displayed.

Cleaned up a few typos encountered while coding.

Redesigned WidgetUpdateService to reliably handle system clock ticks (minute boundaries) so that Gear Widget time stays minute-accurate.

Added new home screen widget designed to be used with Wearable Widgets as a watch face for the Samsung Galaxy Gear 2/3 smartwatch.

Cleaned up logic of WidgetUpdateService to always run and capture clock ticks. This is necessary to keep the time accurate on the widget.

further improved startup logic to make tick capture fully reliable.

minor alignment adjustments

modified slopeToArrowSymbol to add intermediate indexing function -- future use in selecting arrow images on gear widget

method ReadPerfs => ReadPrefs

added slight dimmed alpha bkgd for time/date and BG readings so graph line doesn't interfere with readability when it's behind the letters

jamorham · 2018-01-30T22:51:16Z

Hi there, thanks for this. I haven't reviewed the code in any detail yet and I will likely have more questions. But at the moment it appears there is a merge conflict because of refactoring which has occurred to the master branch after your made your fork. The test which fails so far is that the static preferences reading has been moved to its own Pref class.

You should either try to merge the upstream master and update your code accordingly or simply add the Pref class to your tree and change the failing bits of code which still access it when it used to be inside Home

dwallersv · 2018-01-31T04:09:36Z

Howdy. Yeah, I saw the build error checking on github, and was going to do exactly what you suggest, merging with the current master. Sorry I didn't get to it sooner -- moving in the middle of all of this, was off the radar for a few days. I'll grab the current master, merge it, test, and do another pull request. Dave From: JamOrHam <notifications@github.com> To: jamorham/xDrip-plus <xDrip-plus@noreply.github.com> Cc: dwallersv <david@davidwaller.net>; Author <author@noreply.github.com> Sent: Tuesday, January 30, 2018 2:51 PM Subject: Re: [jamorham/xDrip-plus] Widget for Galaxy Gear S2/3 watchface using Wearable Widgets (#47) Hi there, thanks for this. I haven't reviewed the code in any detail yet and I will likely have more questions. But at the moment it appears there is a merge conflict because of refactoring which has occurred to the master branch after your made your fork. The test which fails so far is that the static preferences reading has been moved to its own Pref class.You should either try to merge the upstream master and update your code accordingly or simply add the Pref class to your tree and change the failing bits of code which still access it when it used to be inside Home— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

dwallersv · 2018-01-31T14:30:38Z

merged the current upstream master, made the changes for the Pref class refactor. Built, tested. I'll keep watch to see if it passes the automated tests.

jamorham · 2018-02-02T11:58:15Z

app/src/main/java/com/eveningoutpost/dexdrip/WidgetUpdateService.java

@@ -55,61 +35,41 @@ public WidgetUpdateService() {}

    @Override
    public void onCreate() {
+        context = getApplicationContext();


Don't store the application context in a static field here, just use xdrip.getAppContext() if you need it from static, otherwise just store it in a local variable.

I'll make the change.

jamorham · 2018-02-02T12:00:22Z

app/src/main/java/com/eveningoutpost/dexdrip/Models/BgReading.java

        }
    }

+    public static String slopeToArrowSymbol(double slope) {


Can you explain the reason for refactoring this method?

The up-right and down-right arrow symbols from the font are visually very different than the normal up, down, and right arrows. I did this refactoring in preparation to add some pure images for the arrows, and was going to refactor the gear widget to use them. Never got around to finishing it, but I intend to in the near future.

I've got the code in a local branch, I'll remove it for now so it's not confusing.

jamorham · 2018-02-02T12:13:39Z

app/src/main/java/com/eveningoutpost/dexdrip/xdrip.java

@@ -46,6 +47,10 @@
    public void onCreate() {
        xdrip.context = getApplicationContext();
        super.onCreate();
+
+        //start widget update service to capture time ticks
+        this.startService(new Intent(this, WidgetUpdateService.class));


This is a problem because its going to enable the service even if no widgets are active. How about I make a new preference option in Smart Watch Features for Galaxy Gear / Wearable Widgets with an option users can enable. We can then make this early start conditional on that?

I don't think we need to add another setting for this. The existence of Gear widgets can be determined dynamically, so the service (and the clock tick event) can be handled properly.

Frankly, I was too focused on the Gear widget when I was doing this that I forgot about making sure the original widget was being handled properly. More in the next comment...

jamorham · 2018-02-02T12:21:01Z

app/src/main/java/com/eveningoutpost/dexdrip/WidgetUpdateService.java

        Log.d(TAG, "enableClockTicks");
        IntentFilter intentFilter = new IntentFilter();
        intentFilter.addAction(Intent.ACTION_TIME_TICK);
-        intentFilter.addAction(Intent.ACTION_SCREEN_ON);


It looks from the diff like this will always be listening for clock ticks. This isn't good for anyone who isn't using wearable widgets from a power saving point of view so I would suggest that the original behavior is restored but with it always enabling listening for clock ticks when the wearable widgets preference item I suggested is enabled. I can add that item in today so you have something to work with easily.

jamorham · 2018-02-02T12:38:43Z

Thanks for submitting this. I know there are gear users who are looking for this feature.

I have added some by line questions where I think changes are needed. In the CONTRIBUTING.md file there is a section about impacts on existing functionality and controlling changes to behavior with a preference switch. The changes I'm looking for are really down to this. The effect that merging this would have on users who are not part of this use case, eg not using wearable widgets.

I plan to add the preference item later today so you can hook on to that for the changes.

abutmim · 2018-07-14T18:32:11Z

Widget for Galaxy Gear S2/3 watchface using Wearable Widgets

is it available?

abutmim · 2018-07-24T03:34:34Z

how can I show time in the Widget in Galaxy Gear S2/3 watchface using Wearable Widgets ?

dwallersv added 11 commits January 18, 2018 07:11

framework for gear widget

ab3e78a

added gear_widget

6e1d1de

Added new home screen widget designed to be used with Wearable Widgets as a watch face for the Samsung Galaxy Gear 2/3 smartwatch.

Improved widget update service

5db8f51

Cleaned up logic of WidgetUpdateService to always run and capture clock ticks. This is necessary to keep the time accurate on the widget.

WidgetUpdateService improvements

ca4f505

further improved startup logic to make tick capture fully reliable.

widget layout tweaks

6f7a2df

minor alignment adjustments

Index function for trend arrow

8a12204

modified slopeToArrowSymbol to add intermediate indexing function -- future use in selecting arrow images on gear widget

updated preview image

baf85b2

layout tweaks

6331341

typo fix

44b0bb6

method ReadPerfs => ReadPrefs

widget update from color change

5314316

gear widget readability

2684df9

added slight dimmed alpha bkgd for time/date and BG readings so graph line doesn't interfere with readability when it's behind the letters

dwallersv added 2 commits January 30, 2018 20:49

Merge remote-tracking branch 'upstream/master'

a433c28

Code refactoring for Pref class

101e626

dwallersv closed this Jan 31, 2018

dwallersv reopened this Jan 31, 2018

jamorham reviewed Feb 2, 2018

View reviewed changes

dwallersv added 2 commits July 18, 2018 12:39

multiple snooze times notification

07fac2b

Merge remote-tracking branch 'upstream/master'

d231998

Merge remote-tracking branch 'upstream/master'

02e62e6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Widget for Galaxy Gear S2/3 watchface using Wearable Widgets #47

Widget for Galaxy Gear S2/3 watchface using Wearable Widgets #47

dwallersv commented Jan 28, 2018

jamorham commented Jan 30, 2018

dwallersv commented Jan 31, 2018 via email

dwallersv commented Jan 31, 2018

jamorham Feb 2, 2018

dwallersv Feb 6, 2018

jamorham Feb 2, 2018

dwallersv Feb 6, 2018

jamorham Feb 2, 2018

dwallersv Feb 6, 2018

jamorham Feb 2, 2018

jamorham commented Feb 2, 2018

abutmim commented Jul 14, 2018

abutmim commented Jul 24, 2018

Widget for Galaxy Gear S2/3 watchface using Wearable Widgets #47

Are you sure you want to change the base?

Widget for Galaxy Gear S2/3 watchface using Wearable Widgets #47

Conversation

dwallersv commented Jan 28, 2018

jamorham commented Jan 30, 2018

dwallersv commented Jan 31, 2018 via email

dwallersv commented Jan 31, 2018

jamorham Feb 2, 2018

Choose a reason for hiding this comment

dwallersv Feb 6, 2018

Choose a reason for hiding this comment

jamorham Feb 2, 2018

Choose a reason for hiding this comment

dwallersv Feb 6, 2018

Choose a reason for hiding this comment

jamorham Feb 2, 2018

Choose a reason for hiding this comment

dwallersv Feb 6, 2018

Choose a reason for hiding this comment

jamorham Feb 2, 2018

Choose a reason for hiding this comment

jamorham commented Feb 2, 2018

abutmim commented Jul 14, 2018

abutmim commented Jul 24, 2018