Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typos and creating a WORDLIST #395

Closed
wants to merge 7 commits into from
Closed

Conversation

sjentsch
Copy link
Member

@sjentsch sjentsch commented Oct 4, 2023

It's mainly fixing typo's and creating a WORDLIST (used by devtools::spell_check()). Australian English wasn't available, hence the en-GB in DESCRIPTION.
I wasn't able to build this version, but I checked devtools::run_examples(run_dontrun = TRUE) and devtools::test() which both run through.

NAMESPACE Outdated
importFrom(jmvcore,table)
importFrom(jmvcore,the)
importFrom(jmvcore,they)
importFrom(jmvcore,warnings)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all super-helpful, but i assume you can see this NAMESPACE just isn't right ... the unit-tests correctly point out that none of these functions occur in jmvcore.

if you wanted to push this forward, and it would be really helpful if you did, you could investigate what's going on here. i think i've seen this before, and i think the way i solve it is to use roxygen2 6.1.1 ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you aware of any method that enforces a particular version of Roxygen? Whenever I run commands from devtools, it seems to forcibly change the Roxygen-version to 7.2.3.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can get the 6.1.1 here and install it with R CMD install roxygen2_6.1.1.tar.gz or similar.

@sjentsch sjentsch closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants