Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding multiple vehicles no unique sensors #5

Closed
si458 opened this issue Dec 24, 2023 · 11 comments · Fixed by #9
Closed

adding multiple vehicles no unique sensors #5

si458 opened this issue Dec 24, 2023 · 11 comments · Fixed by #9

Comments

@si458
Copy link
Contributor

si458 commented Dec 24, 2023

Hi
Brilliant integration, just one nit pick,
When u add multiple vehicles, the sensors aren't really being unique
For example the mot due date is sensor.mot_expiry_date and sensor.mot_expiry_date_2
Where as the dvla calender entry is calendar.dvla_reg123 and calendar.dvla_reg1234
Can the sensor ids be changed to include the reg in front of the name?

@jampez77
Copy link
Owner

Firstly, thanks for using the integration and thanks for taking the time to give a suggestion. I like that idea and have added it to the to do list.

@madmic1314
Copy link

Brilliant integration - I second this change as well - we have 3 vehicles and it's difficult to keep track.

Some ideas on the sensor name could be sensor.reg.xxx or sensor.manufacturer.xxx ? The second might be difficult if people have two of the same model vehicles.

@spiderlane
Copy link

Yes this would be very useful. I really like the individual sensors (previously I used template sensors to split out the attributes) but ideally they need to be prefixed with the registration for use with more than one car.

@rudgej
Copy link

rudgej commented Jan 5, 2024

Hello. I did ask a separate question but no reply and I figured replying to this might ask a wider audience.

There are no setup instructions and nowhere to put the api key in the HACS integration.

Can anyone tell me where the key goes and how to call this service please ?

Thanks

@si458
Copy link
Contributor Author

si458 commented Jan 5, 2024

@rudgej Once u added it in hacs, just install, it, restart ha, then fo into integrations then add the dvla, and put ur key/reg in there

@rudgej
Copy link

rudgej commented Jan 5, 2024 via email

@si458
Copy link
Contributor Author

si458 commented Jan 5, 2024

@rudgej NO the integration isnt designed for that!
its designed to add say your own car(s) into HA to check dates of MOT, etc, and it creates devices with entities of them
you cant call a function/automation/service to check a RANDOM car,
(you would have to somehow add the integration every time you saw a reg, wait for it to setup/reply from entities then remove the integration! seems very hard work)

@rudgej
Copy link

rudgej commented Jan 6, 2024

Ok thanks. I will see what I can do to call the api directly.

What I want to do it run all cars that come up on my Anpr feed and put them into a Google docs spreadsheet . Will see how I get on.

@si458
Copy link
Contributor Author

si458 commented Jan 6, 2024

Ok thanks. I will see what I can do to call the api directly.

What I want to do it run all cars that come up on my Anpr feed and put them into a Google docs spreadsheet . Will see how I get on.

Yeh that won't work, unless u maybe modified the integration to add a service, which u can then input the reg and call, which then passes that reg to dvla and returns data

@rich-kettlewell
Copy link

+1 on improving the sensor names.

my 2 cars have now created sensors called "sensor.colour" and "sensor_colour_2" .. far too generic :-)

@si458
Copy link
Contributor Author

si458 commented Jan 10, 2024

fixed i think all, works perfectly on my setup, 2 missing lines
will use

binary_sensor.dvla_REGHERELOWERCASE_DESCRIPTION
sensor.dvla_REGHERELOWERCASE_DESCRIPTION
calendar.dvla_REGHERELOWERCASE

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants