Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: always check only for the first ib affiliates #127

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

greymag
Copy link
Contributor

@greymag greymag commented Feb 28, 2024

In the previous version of the code, getIbAffiliateInfo() returned empty data if the first entry in ibAffiliateInfos had a different code.

@pronebird
Copy link
Contributor

Legit. 👍

@lanzagar
Copy link

I noticed this as well. My suggestion is to de-indent by one more step, so that it is outside the if os.path.isfile("ib-affiliates.xml") in case the file cannot be created for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants