Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FXCFD #83

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Add FXCFD #83

merged 2 commits into from
Feb 22, 2023

Conversation

pronebird
Copy link
Contributor

  • Add FXCFD type which is basically CFD on FX
  • Throw an error when script stumbles upon unknown asset type. Should help with pin pointing this kind of issues in the future.

@pronebird pronebird mentioned this pull request Feb 22, 2023
Closed
@jamsix
Copy link
Owner

jamsix commented Feb 22, 2023 •
edited
Loading

I think you need to replace these:

ib-edavki/ib_edavki.py

Line 909 in 233acbb

elif trades[0]["assetCategory"] == "CFD":

ib-edavki/ib_edavki.py

Line 997 in 233acbb

elif trades[0]["assetCategory"] == "CFD":

with:

elif trades[0]["assetCategory"] in ["CFD", "FXCFD"]:

@jamsix jamsix self-assigned this Feb 22, 2023
@pronebird
Copy link
Contributor Author

@jamsix Fixed.

@jamsix
Copy link
Owner

jamsix commented Feb 22, 2023

LGTM!

@jamsix jamsix merged commit fadd087 into jamsix:master Feb 22, 2023
@pronebird pronebird deleted the add-fxcfd branch February 22, 2023 08:14
@mfilej mfilej mentioned this pull request Feb 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jamsix jamsix

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pronebird @jamsix