Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract JS from React lib #28

Merged
merged 6 commits into from
Feb 7, 2023
Merged

Extract JS from React lib #28

merged 6 commits into from
Feb 7, 2023

Conversation

paulgb
Copy link
Member

@paulgb paulgb commented Feb 5, 2023

First step of #22, and also a step on the path to first-class support for non-React frameworks.

  • Move logic of useSharedState into driftdb
  • Move logic of usePresence into driftdb
  • Move logic of useUniqueClientID into driftdb
  • Move logic of useSharedReducer into driftdb

This will also make the inner logic of these functions more testable, but adding tests is beyond the scope of this PR.

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-28.d1e3k9mrxdtuk7.amplifyapp.com

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-28.d1kjso0mfqvoj7.amplifyapp.com

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-28.d1waxv6v9r5tig.amplifyapp.com

@paulgb paulgb merged commit 385a350 into main Feb 7, 2023
@rolyatmax rolyatmax deleted the paulgb/extract-js-from-react-lib branch February 7, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant