Abhi/dis 428 spawner pipe docker stats output to nats #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulgb
reviewed
Jul 25, 2022
pretentious7
force-pushed
the
abhi/dis-428-spawner-pipe-docker-stats-output-to-nats
branch
from
f10662f
to
aacb832
Compare
paulgb
approved these changes
Jul 30, 2022
rolyatmax
deleted the
abhi/dis-428-spawner-pipe-docker-stats-output-to-nats
branch
pretentious7
added a commit
that referenced
this pull request
Aug 5, 2022
This reverts commit 616afb2. PROBLEM: when a container is swept, stats continue, except with CPU null SOLUTION: needs investigation, revert changeset for now and come back to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized I didn't put this in as a pr yet, modeled it off the way logs work. Very unsure about both exact design and the stats being passed, as well as the test. But its a start!