Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Docusaurus starter repo URL #609

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Updates Docusaurus starter repo URL #609

wants to merge 1 commit into from

Conversation

zachleat
Copy link
Member

Fixes #462

@netlify
Copy link

netlify bot commented Jul 12, 2021

✔️ Deploy Preview for jamstack-site ready!

🔨 Explore the source changes: cdb0395

🔍 Inspect the deploy log: https://app.netlify.com/sites/jamstack-site/deploys/60ecb358d626b012bed6f059

😎 Browse the preview: https://deploy-preview-609--jamstack-site.netlify.app

@slorber
Copy link

slorber commented Jul 16, 2021

Thanks @zachleat

But is this really going to work with a git subpath like that?

According to my tests a few months ago you don't support that?

https://app.netlify.com/start/deploy?repository=https://github.com/facebook/docusaurus/tree/master/examples/classic

image

@zachleat
Copy link
Member Author

zachleat commented Jul 16, 2021

Oh, good call. I know we do have a base option in netlify.toml for this—lemme ask around if it’s available to the Deploy to Netlify button.

(switching to Draft status here)

@zachleat zachleat marked this pull request as draft July 16, 2021 15:17
@zachleat zachleat removed the request for review from philhawksworth July 16, 2021 15:17
@zachleat
Copy link
Member Author

zachleat commented Jul 21, 2021

I heard back, this is officially blocked on a feature-add to the deploy button. I’ll circle back when movement happens over there—not sure I have a recommendation on what to do until then, maybe we need to remove the deploy button for now

@slorber
Copy link

slorber commented Jul 22, 2021

Thanks

I was wondering if you are able to use a root folder on a dedicated branch?

Use this if possible: https://github.com/facebook/docusaurus/tree/starter

Otherwise let's use this one that I created and plan to keep up to date: https://github.com/slorber/docusaurus-starter

Going to set up a little automation for that: git subtree push --prefix examples/classic --squash git@github.com:slorber/docusaurus-starter.git main --squash

Copy link

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping :)

Using https://github.com/slorber/docusaurus-starter should work and it is better than current URL.

I'd like to have an official FB URL for the starter repo, but in the meantime it is good enough.

@@ -10,7 +10,7 @@ templates:
- React
- Markdown
description: 'Build optimized websites quickly, focus on your content'
startertemplaterepo: https://github.com/anishkny/docusaurus-base
startertemplaterepo: https://github.com/facebook/docusaurus/tree/master/examples/classic
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
startertemplaterepo: https://github.com/facebook/docusaurus/tree/master/examples/classic
startertemplaterepo: https://github.com/slorber/docusaurus-starter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Docusaurus deploy button
2 participants