Fix #1622 WhatsThis #1635
Fix #1622 WhatsThis #1635
Conversation
|
Thank you! I've been meaning to do this for ages. |
| "Select the skin to be used for the main window." ) ); | ||
|
|
||
| cbxSkin->setAccessibleName ( tr ( "Skin combo box" ) ); | ||
|
|
||
| // Interface Language |
There was a problem hiding this comment.
If this is new, it's going to need calling out to the translators, as the cut's been taken.
There was a problem hiding this comment.
If this is new, it's going to need calling out to the translators, as the cut's been taken.
As far as I can see, this string does not appear in 3.8.0beta1 (even in other places), so it is new, yes.
I'd rather not restart translations for that. One option would be to merge this explicitly after all other translation PRs have been merged. This has the obvious downside that the new strings will not be translated for 3.8.0, but as it is only about a rather hidden text and hasn't been working before either, I think it would be acceptable to do so.
I'm therefore not approving yet.
There was a problem hiding this comment.
Yes, the Language whatsthis is new.
Other possibility is I take it out now, as it didn't exist before, and try to remember to put it back in for the next version.
- Minimum size showing all text is no longer enforced, the window can be made thinner, but the text is cut off if needed. - "Enable Small Network Buffers" now on 2 lines to reduce width. - the default width shows all text.
|
Anyone know why it is not resolving? |
Looks like there are no more conflicts now. :) |
|
Ja, I just resolved it here a second time. Waiting now for the build to finish so I can check it. |
As the WhatsThis connections in the clientsettingsdlg to comboboxes and
edit fields were all not working they have been moved to the the
corresponding labels.