Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pt_BR app translation for 3.8.0 #1671

Merged
merged 1 commit into from May 11, 2021
Merged

Update pt_BR app translation for 3.8.0 #1671

merged 1 commit into from May 11, 2021

Conversation

melcon
Copy link
Contributor

@melcon melcon commented May 10, 2021

Fixes #1613

@hoffie hoffie added this to the Release 3.8.0 milestone May 10, 2021
@hoffie hoffie added this to Triage in Tracking (old) via automation May 10, 2021
@hoffie hoffie moved this from Triage to Waiting on Team in Tracking (old) May 10, 2021
hoffie
hoffie approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :)

  • Translator listed in the src/util.cpp optionally add link to PR or code
  • Punctuation and spacing consistent
  • Signal words consistent ("ASIO", "Buffer")
  • App translations: No untranslated strings (grep unfinished -5 src/res/translation/translation_$TRANSLATION*.ts)
  • App translations: Only a single .ts file checked in
  • Installer translations: Passes tools/check-wininstaller-translations.sh

@hoffie hoffie requested a review from gilgongo May 10, 2021 22:15
@gilgongo gilgongo merged commit 29947bd into jamulussoftware:master May 11, 2021
Tracking (old) automation moved this from Waiting on Team to Done May 11, 2021
@melcon melcon deleted the translate-pt_BR-3.8.0 branch May 17, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffie hoffie hoffie approved these changes

@gilgongo gilgongo Awaiting requested review from gilgongo

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Tracking (old)
Done
Milestone
Release 3.8.0
Development

Successfully merging this pull request may close these issues.

Update pt_BR app translation for 3.8.0
3 participants
@melcon @hoffie @gilgongo