Muted Speaker Icon update #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
approved these changes
May 16, 2021
softins
requested changes
May 16, 2021
henkdegroot
force-pushed
the
ReplaceMutedSpeaker
branch
from
6481b14
to
1ef7caa
Compare
|
@softins , updated as requested |
hoffie
approved these changes
May 16, 2021
softins
approved these changes
May 16, 2021
There was a problem hiding this comment.
Looks good!
When revisiting this after the release, to change to the ear icon, we should clarify the What's This text: the icon showing just means the client cannot hear you. It might not be because they have you muted (which is what the text says), because it also shows if you turn your own fader right down.
|
The 'muted speaker' in jamulus-3.8.0rc1looks good and works good. Please keep it this way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1684