New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: add zh_CN translation #1922
Conversation
Hi, thank you! Adding new languages is always great! Finally a non European language ;-). Tagging @softins here (he knows the translation process well). Be prepared to get some more information on the translation process soon. |
Actually, I think we don’t have a non technical translator onboarding for the app… So just some quick notes here:
Not sure if I missed something. I‘d suggest you to open a GitHub discussion if you plan to contribute more (=Tell the community that you’re a new translator). Maybe someone else can also help out with Chinese? Just from a personal perspective: can you check if the GUI is OK after the translation? Non ASCII letters aren’t that common in the app yet. |
Totally understand, and feel free to tag me when you need to update the zh_CN translation :)
I'd love to, thanks.
Will do that later.
Yeah, it's okay. I got the program compiled on my Windows installation with my MSYS2/MinGW64 environment and it works fine :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That seems like a lot of work. See my comments. They're not all addressed to you ;-).
</message> | ||
<message> | ||
<location filename="../../util.cpp" line="392"/> | ||
<source>There is a server which collects the audio data from each client, mixes the audio data and sends the mix back to each client.</source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue in English: there's a space too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While working on the translation, I found there are also some other issues in the original translation strings, I will discuss them in separated issue or PR after this one get merged :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Thanks. Would be great.
<message> | ||
<location filename="../../aboutdlgbase.ui" line="72"/> | ||
<source>Copyright (C) 2005-2021 The Jamulus Development Team</source> | ||
<translation>版权所有 (C) 2005-2021 Jamulus 开发团队</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you don't need to translate Development Team, but that's fully up to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the whole "The Jamulus Development Team" is a trademark or something, I think I would avoid translate Development Team as 开发团队, if not, I recommend to translate it :)
</message> | ||
<message> | ||
<location filename="../../audiomixerboard.cpp" line="1112"/> | ||
<source>Personal Mix at: </source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should be translated before a merge since it's prominent on the mixing board.
<message> | ||
<source>List</source> | ||
<translation type="vanished">列表</translation> | ||
</message> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this (and all the other translations which have vanished) don't need a translation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I actually did the translation by editing the italian ts file and generate qm file use the linguist application and then I realized Jamulus did embed the qm files to resource file instead distribute qm files inside the translation folder. Then I cloned the full source, added the ts and qm file that I already translated, then run lrelease
and reworked some translation and compile it manually. The vanished strings are the ones I did translated before I get compile the program by myself.
</message> | ||
<message> | ||
<location filename="../../util.h" line="618"/> | ||
<source>Requirements not fulfilled</source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tagging @gilgongo here. I doubt this error message is user friendly... Should we open an issue on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we should re-write that. Wonder what it refers to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably if the directory rejects the server to register with it?
Line 586 in 27f9a35
SRS_NOT_FULFILL_REQUIREMENTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Need to test/compile it locally on Debian before another review round ;-).
Before this can get merged, we need:
- a proposal for the change log entry (Something like Translation: Added Chinese translation)
- … to add you to the utils file
- … another approving review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Translator listed in the
src/util.cpp
optionally add link to PR or code - Looks consistent
- Passes
tools/check-wininstaller-translations.sh
(No Chinese translation for installer)
@BLumia, I'm interested in your compilation workflow with MSYS2/MinGW64. I used the MinGW environment for compiling on Windows about 8 years ago when contributing to MuseScore (which also uses Qt), but I haven't used it since then. Please could you send a few notes on it? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done a check for duplicated accelerator keys and found five instances, which I have flagged. Everything else looks fine (although I have no idea about the Chinese!)
With MSYS2 it's actually quite easy to compile it. I got MuseScore might need a lot of other build depts so it might be more complex than compile Jamulus, I haven't tried to compile MuseScore, though. BTW I use MSYS2 to compile a lot of my own stuff and I already got some other libs installed from MSYS2 repo while doing that, so I'm not sure if Jamulus need any additional depts other than Qt and ASIO SDK that I already installed before. |
Short description of changes
Add zh_CN translation
Context: Fixes an issue?
Not a bugfix patch.
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Most of the zh_CN translations are done, some of them still need to work but I suggest merge this patch first. I might still need some time to understand some of its features and some other translation strings may need to be changed (I'll open a new issue or PR for that once I'm ready)
What is missing until this pull request can be merged?
Waiting on second review; Add BLumia to translators in util file;
Checklist