Add recording support with Reaper Project generation #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes the following changes
* Initial .gitignore
Administrative
* Fix up warning message
* Not all Windows file systems are case insensitive
Bugfixes
* (Qt5) Use QCoreApplication for headless
Possible solution to get the application to run as a headless server but it loses the nice history graph, so not ideal.
* Avoid ESC closing chat
Because ESC shouldn't close the chat window. Or the main app window.
* Add console logging support for Windows
Whilst looking for the headless support, I found this idea for Windows logging. New improved version. This makes far fewer changes.
----
* Add recording support with Reaper Project generation
The main feature!
* New -r option to enable recording of PCM files and conversion to Reaper RPP with WAV files
* New -R option to set the directory in which to create recording sessions
You need to specify the -R option, there's no default... so I guess -r and -R could be combined.
* New -T option to convert a session directory with PCM files into a Reaper RPP with WAV files
You can use -T on "failed" sessions, if the -r option captures the PCMs but the RPP converter doesn't run for some reaon. (It was useful during development, maybe less so once things seem stable.)
The recorder is implemented as a new thread with queuing from the main "real time" server thread.
When a new client connects or if its audio format changes (e.g. mono to stereo), a new RIFF WAVE file is started. Each frame of decompressed audio for each client written out as LPCM to the file. When the client disconnects, the RIFF WAVE headers are updated to reflect the file length.
Once all clients disconnect, the session is considered ended and a Reaper RPP file is written.
Feature/pljones audio stream saving
doloopuntil
pushed a commit
to doloopuntil/jamulus
that referenced
this pull request
Apr 21, 2020
doloopuntil
pushed a commit
to doloopuntil/jamulus
that referenced
this pull request
Apr 22, 2020
corrados
pushed a commit
that referenced
this pull request
May 10, 2020
bug fix: fixed that Jamulus segfaults when jackd is restarted (Ticket…
corrados
pushed a commit
that referenced
this pull request
May 23, 2020
corrados
pushed a commit
that referenced
this pull request
Jun 5, 2020
corrados
pushed a commit
that referenced
this pull request
Jun 8, 2020
corrados
pushed a commit
that referenced
this pull request
Jun 19, 2020
corrados
pushed a commit
that referenced
this pull request
Jul 10, 2020
corrados
pushed a commit
that referenced
this pull request
Jul 17, 2020
add the names of the instrument icon creators to the contributors lis…
corrados
pushed a commit
that referenced
this pull request
Aug 12, 2020
Closed
npostavs
pushed a commit
to npostavs/jamulus
that referenced
this pull request
Feb 11, 2021
Make CJamStreamer::process data parameter a reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following changes
Initial .gitignore
Administrative
Fix up warning message
Not all Windows file systems are case insensitive
Bugfixes
(Qt5) Use QCoreApplication for headless
Possible solution to get the application to run as a headless server but it loses the nice history graph, so not ideal.
Avoid ESC closing chat
Because ESC shouldn't close the chat window. Or the main app window.
Add console logging support for Windows
Whilst looking for the headless support, I found this idea for Windows logging. New improved version. This makes far fewer changes.
The main feature!
You need to specify the -R option, there's no default... so I guess -r and -R could be combined.
You can use -T on "failed" sessions, if the -r option captures the PCMs but the RPP converter doesn't run for some reaon. (It was useful during development, maybe less so once things seem stable.)
The recorder is implemented as a new thread with queuing from the main "real time" server thread.
When a new client connects or if its audio format changes (e.g. mono to stereo), a new RIFF WAVE file is started. Each frame of decompressed audio for each client written out as LPCM to the file. When the client disconnects, the RIFF WAVE headers are updated to reflect the file length.
Once all clients disconnect, the session is considered ended and a Reaper RPP file is written.