Use the default server name in the mixer

[pljones]

Short description of changes

Edge-case for user using no server details and clicking "connect" from the connect window. They could be looking at any of the directories when they hit connect. For example:

Hitting "Connect" used to title the mixer "Directory Server" (or translation). Now it titles it with the default directory name as more of a clue:

Does this change need documentation? What needs to be documented and how?

No.

Translations needed.

Status of this Pull Request

Working as expected.

What is missing until this pull request can be merged?

Should just work (except for translations changing).

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[pljones]

Awaiting this over on https://github.com/pljones/jamulus

• patch/ocd-reorder-of-settings
• patch/ocd-reorder-of-serverdlg-bits
  These two pretty much don't change anything, just put the code through a "mental sort", so I could follow it better. Mostly because they're areas I'm planning to change... and indeed...
• feature/server-list-persistence-ui
  Adds a UI to allow the server list persistence file to be set. Plus changing rather a lot of other stuff to make changes in the UI not need the server stopped and started.

[ann0see]

How/where is AT_DEFAULT set?

Also: shouldn’t we rename the directory server at any genre to match your label?

[pljones]

How/where is AT_DEFAULT set?

grep is your friend. src/util.h line 547.

Also: shouldn’t we rename the directory server at any genre to match your label?

Not given this is for an edge case, I don't think. I'm only changing it from what it was so it's clearer you're not necessarily somewhere related to what you were looking at.

[ann0see]

Hmm. I think the main problem is that connecting to the Any Genre 1 directory while being in Any Genre 2 or similar is the confusing part. And this can't be fixed with this (rather visual) approach. OFC, it's much better with your approach, but I think we should rather change functionality of this button if we're in another genre...

[ann0see]

Although untested, the code looks simple enough to approve.

[ann0see]

BTW: Thanks for the "next big thing" work on Jamulus.

[softins]

Just tried this out and it works fine, so I'm happy to approve, as it doesn't change existing functionality.

But I do think the existing functionality is wrong. An improvement would be to connect to the directory server of the currently-displayed list, but I think the right behaviour going forward would be: if no server in the list is selected, AND the server address box is blank, the Connect button is disabled.

[pljones]

Just tried this out and it works fine, so I'm happy to approve, as it doesn't change existing functionality.

But I do think the existing functionality is wrong. An improvement would be to connect to the directory server of the currently-displayed list, but I think the right behaviour going forward would be: if no server in the list is selected, AND the server address box is blank, the Connect button is disabled.

Yes, it's a bit weird now, the way it is. (Before multiple servers, it just connected to Volker's server, of course, which sort of made sense.)

I'd like to have "Escape" work on the connect dialog along with getting rid of this "default" behavour, too. (There was a patch to turn off "Escape" on all the dialogs - I'm not entirely sure why...)