Scripts: Set -o pipefail

[hoffie]

Short description of changes
This is supposed to avoid silent failures when using pipes.
Example: #2793 (https://github.com/hoffie/jamulus/runs/7930874876?check_suite_focus=true#step:9:42)

CHANGELOG: Internal: Hardened build scripts and tooling against silent failures.

Context: Fixes an issue?

Does this change need documentation? What needs to be documented and how?
No.

Status of this Pull Request

What is missing until this pull request can be merged?

• CI green
• tools/ needs explicit review/testing for pipe usage.

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[hoffie]

Testable tooling (e.g. translation checker, copyright updates) tested. All scripts reviewed for potential unwanted side effects (little pipe usage and where pipes are used, they should be checked properly).

The Linux CI failure is expected and is a proof of this change working properly. It will go once #2793 is merged and the PR is rebased.

[ann0see]

I think you should now rebase this PR?

[hoffie]

Rebased. Linux builds are green now as well, as expected.

[pljones]

Hi @hoffie,

I had to do this:
b333de3
I'd guess the "pipefail" change meant I now got a silent failure - rather than preventing one, it caused it. || true ignores the fail... Just a hack to get the script working for now.