-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: Move Linux distribution/ files to linux/ #2838
Conversation
38ab6fb
to
c012232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good, not tried it out though... The deb build failed, however...
Yes, this still needs some investigation. |
I think I know what happened. The branch is NOT ok: the debian folder got lost |
c012232
to
5904a78
Compare
5904a78
to
0f5aeb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's only the dependeny issue again, now.
It looks ok on Debian too. @corrados should know that this Pull Request moves raspijamulus.sh to the linux/ folder. In future we might move it again, depending on the restructuring of the repo layout. |
Thanks for letting me know. It's totally fine with me :-). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After careful diff scanning, this looks fine to me... :)
Thanks @corrados for your OK. |
Short description of changes
Moves Linux distribution files to linux/ folder and icons to src/res. We might even be able to reuse some of the images now.
CHANGELOG: Refactoring: Moved around files to clean up the repository
Context: Fixes an issue?
Related to: #2601
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
To be tested on Raspberry Pi with raspijamulus
What is missing until this pull request can be merged?
Review and decision on the weather we rename deb-mainicon.* to deb-jamulus.* since that's describing more what the file actually is. However that would break the naming style of Windows and macOS icons.
Checklist