Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Windows Installer translation to en_GB #2929

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Oct 20, 2022

Short description of changes

Renames the .nsi windows installer base file to en_GB.

CHANGELOG: Internal: Renamed English translation file of windows installer to en_GB

Context: Fixes an issue?

Fixes: #2886

Does this change need documentation? What needs to be documented and how?

/. Just needs an update on Weblate

Status of this Pull Request
Ready to merge. Afterwards weblate needs to be updated.

What is missing until this pull request can be merged?

Final Review

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added this to Triage in Tracking (old) via automation Oct 20, 2022
@ann0see ann0see added this to the Release 3.10.0 milestone Oct 20, 2022
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installer still works in English, no old en_UK references found. Looks good to me.

@ann0see ann0see moved this from Triage to Waiting on Team in Tracking (old) Oct 20, 2022
Tracking (old) automation moved this from Waiting on Team to In Progress Oct 20, 2022
@ann0see ann0see merged commit 4c2cdba into jamulussoftware:master Oct 20, 2022
Tracking (old) automation moved this from In Progress to Done Oct 20, 2022
@ann0see ann0see deleted the renameInstaller branch October 20, 2022 21:29
@pljones pljones removed this from Done in Tracking (old) Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Change windows installer language code to en_GB
3 participants