Display server title correctly in dark mode #3008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
reviewed
Feb 13, 2023
| @@ -1358,7 +1358,6 @@ void CClientDlg::SetGUIDesign ( const EGUIDesign eNewDesign ) | |||
| " image: url(:/png/fader/res/ledbuttonpressed.png); }" | |||
| "QCheckBox { color: rgb(220, 220, 220);" | |||
| " font: bold; }" ); | |||
|
|
|||
There was a problem hiding this comment.
Unrelated delete of blank line?
pljones
approved these changes
Feb 13, 2023
|
@gilgongo as it’s UI related, can you confirm that it’s ok? Darkmode in general seems to work ok. There might be some contrast issues I didn’t find yet. The server GUI might need some minor contrast adjustments for the Registered/Not registered messages. |
|
@gilgongo could you please review this PR? |
|
@gilgongo Do your thumbs up mean that this PR is ok to go in? If yes, please approve and merge. |
|
Sorry - I wasn't sure if I was setting up dark mode correctly (I'm using Ubuntu 22.10) but it seemed OK to me. |
gilgongo
approved these changes
Apr 19, 2023
|
Ah ok. For me everything was fine under GNOME. So I believe it's ok. But I'm using Debian 12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Fixes the color of the Server name in dark mode on Linux (Gnome, Qt6, Debian 12). This should also work on macOS. Edit: it does.
Without fix:
With fix:
Recording and mute myself doesn't change and looks OK:
CHANGELOG: CONDENSE with #2833
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready for review.
What is missing until this pull request can be merged?
Checklist