Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3050 Save HTML formatting in Server Welcome Message #3058

Conversation

pljones
Copy link
Collaborator

@pljones pljones commented May 1, 2023

Short description of changes

CHANGELOG: Server: Save the HTML formatting in Server Welcome Message. (Applies to the GUI Server.)

Context: Fixes an issue?

Fixes: 3050

Does this change need documentation? What needs to be documented and how?

No.

Status of this Pull Request

Tested locally.

What is missing until this pull request can be merged?

Could do with @kjcole testing one of the builds.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones pljones added this to the Release 3.10.0 milestone May 1, 2023
@pljones pljones linked an issue May 1, 2023 that may be closed by this pull request
@pljones pljones added this to Triage in Tracking (old) via automation May 1, 2023
@pljones pljones added the good first issue Things which should be doable without lots of context label May 1, 2023
@pljones pljones self-assigned this May 1, 2023
@pljones pljones moved this from Triage to Waiting on Team in Tracking (old) May 1, 2023
@pljones pljones force-pushed the bugfix/3050-save-html-for-welcome-message branch from 53df82c to 84b9542 Compare May 10, 2023 16:44
@pljones pljones requested a review from ann0see May 10, 2023 16:44
@ann0see
Copy link
Member

ann0see commented May 11, 2023

@pljones, On the current build, on Debian 10 this error does only occur if I close and reopen twice.

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, it works, but we should probably set the field to not support HTML formatting - or a way to toggle it.

@kjcole
Copy link

kjcole commented May 11, 2023

(I didn't test the builds because I didn't know the builds were -- or if I had to build from source, which source?)

@ann0see
Copy link
Member

ann0see commented May 11, 2023

(I didn't test the builds because I didn't know the builds were -- or if I had to build from source, which source?)

I've just killed the build. This should give you access to the artifacts: https://github.com/jamulussoftware/jamulus/actions/runs/4939367648 (scroll down the page and you should be able to see the files)

If you build from source, you'd need to clone the repository by pljones. then git checkout <branchNameHere> ( = 3050-save-html-for-welcome-message)

@pljones
Copy link
Collaborator Author

pljones commented May 16, 2023

We're onto this, I hope?

Build for MacOS Legacy (artifacts+CodeQL)
This request was automatically failed because there were no enabled runners online to process the request for more than 1 days.
https://github.com/jamulussoftware/jamulus/pull/3058/files#annotation_11242011701
Auto-Build
The macOS-10.15 environment is deprecated, consider switching to macos-11(macos-latest), macos-12 instead. For more details see actions/runner-images#5583

@ann0see
Copy link
Member

ann0see commented May 16, 2023

Yes. See my PRs for iOS and macOS

@pljones
Copy link
Collaborator Author

pljones commented May 17, 2023

Yes. See my PRs for iOS and macOS

Ah right.

@pljones pljones force-pushed the bugfix/3050-save-html-for-welcome-message branch 2 times, most recently from 41c4ac7 to eb3d4b6 Compare May 19, 2023 16:29
@pljones pljones force-pushed the bugfix/3050-save-html-for-welcome-message branch from eb3d4b6 to 203f7c1 Compare May 22, 2023 18:41
@pljones pljones merged commit dce01ab into jamulussoftware:main May 31, 2023
10 checks passed
Tracking (old) automation moved this from Waiting on Team to Done May 31, 2023
@pljones pljones deleted the bugfix/3050-save-html-for-welcome-message branch May 31, 2023 11:43
@ann0see
Copy link
Member

ann0see commented May 31, 2023

@pljones I think this is changelog worthy.

@pljones
Copy link
Collaborator Author

pljones commented May 31, 2023

@pljones I think this is changelog worthy.

Updated the top post. Does that do it?

@ann0see
Copy link
Member

ann0see commented May 31, 2023

Yes. I think so

@pljones pljones removed this from Done in Tracking (old) Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Things which should be doable without lots of context
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Server GUI "forgets" HTML / CSS
3 participants