Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Bump Qt6 from 6.4.3 to 6.5.1 (Automated PR) #3070

Merged
merged 1 commit into from Jul 1, 2023
Merged

Build: Bump Qt6 from 6.4.3 to 6.5.1 (Automated PR) #3070

merged 1 commit into from Jul 1, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented May 16, 2023 •
edited

This automated Pull Request updates the used Qt6 version to version 6.5.1.

This PR was opened by the workflow Bump dependencies (create-prs)

CHANGELOG: Build: Updated bundled Qt6 to version 6.5.1

@ann0see
Copy link
Member

ann0see commented May 16, 2023

Might need to leave this open until a new release comes out.

@pljones
Copy link
Collaborator

pljones commented May 17, 2023

Yeah, don't think this is 3.10.0-ready.

@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 2 times, most recently from e4b3900 to c6a13db Compare May 22, 2023 17:43
@ann0see
Copy link
Member

ann0see commented May 22, 2023

According to the Qt 6.5 release schedule we'll have Qt 6.5.1 in a few days. I hope this will then fix the linking error.

@github-actions github-actions bot changed the title Build: Bump Qt6 from 6.4.3 to 6.5.0 (Automated PR) Build: Bump Qt6 from 6.4.3 to 6.5.1 (Automated PR) May 24, 2023
@github-actions
Copy link
Author

PR has been updated for version 6.5.1 by the workflow Bump dependencies (create-prs).

@ann0see
Copy link
Member

ann0see commented May 24, 2023

So Qt 6.5.1 is out. Let's look and see if it works now

@ann0see ann0see added this to the Release 3.10.0 milestone May 31, 2023
@ann0see ann0see added the dependencies Pull requests that update a dependency file label May 31, 2023
@ann0see ann0see added this to Triage in Tracking (old) via automation May 31, 2023
@ann0see ann0see self-requested a review May 31, 2023 11:42
ann0see
ann0see approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last build seemed to be ok. (ASIO version runs). The unpacking procedure didn't work initially, but I don't think that's related to this build and is a Windows 11 bug on my machine.
macOS is to be tested (but we can do that later too)

@ann0see ann0see moved this from Triage to Waiting on Team in Tracking (old) May 31, 2023
@pljones
Copy link
Collaborator

pljones commented May 31, 2023

https://github.com/jamulussoftware/jamulus/actions/runs/5132866315/jobs/9234723229?pr=3070#step:10:499
Why does it try to delete a bunch of debug files we shouldn't be wasting time creating here?

@ann0see
Copy link
Member

ann0see commented May 31, 2023

Could be a bug? But probably cleaning is necessary as we build for 64 and 32 bit.

@ann0see
Copy link
Member

ann0see commented Jun 3, 2023

macOS seems to be OK. No bug with the my profile screen not showing up.

@hoffie hoffie force-pushed the ci/bump-dependencies/Qt6 branch 3 times, most recently from d4114f9 to 5dc9e79 Compare June 11, 2023 11:28
Tracking (old) automation moved this from Waiting on Team to In Progress Jun 11, 2023
@pljones
Copy link
Collaborator

pljones commented Jun 11, 2023

I'd like to get all builds to Qt6 by default... just have some misgivings still...

@ann0see ann0see merged commit 0a88a91 into main Jul 1, 2023
12 checks passed
Tracking (old) automation moved this from In Progress to Done Jul 1, 2023
@ann0see ann0see deleted the ci/bump-dependencies/Qt6 branch July 1, 2023 19:48
@pljones pljones removed this from Done in Tracking (old) Jul 28, 2023
@pljones
Copy link
Collaborator

pljones commented Jul 29, 2023

KEEP IN VIEW: We discovered Qt 6.5.1 had a problem which was fixed in Qt 6.5.2, so avoid this version.

@ann0see ann0see mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pljones pljones pljones approved these changes

@ann0see ann0see ann0see approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
Tracking
Status: Done
Milestone
Release 3.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ann0see @pljones @actions-user