Build: Move release handling to GH cli #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
commented
May 28, 2023
.github/autobuild/android.sh
Outdated
| @@ -100,10 +100,10 @@ build_app_as_apk() { | |||
| } | |||
|
|
|||
| pass_artifact_to_job() { | |||
| mkdir deploy | |||
| mkdir publish | |||
| local artifact="jamulus_${JAMULUS_BUILD_VERSION}_android.apk" | |||
There was a problem hiding this comment.
uploading everything from the deploy directory doesn’t work as
- GH on Windows doesn‘t support wildcards
- MacOS moves the binary (.app files) to the deploy folder
If instead we upload the files by name - as we do in this state - we could also use the deploy directory directly.
.github/workflows/autobuild.yml
Outdated
| id: upload-release-asset2 | ||
| uses: actions/upload-release-asset@v1 | ||
| id: upload-release-assets | ||
| run: cd publish; gh release upload "${{ needs.create_release.outputs.tag_name }}" ${{ steps.get-artifacts.outputs.artifact_1 }} ${{ steps.get-artifacts.outputs.artifact_2 }} --clobber |
There was a problem hiding this comment.
Not sure if omitting quotes is the best way to "overload" this command. Basically if quotes are omitted we can have an arbitrary amount of files to upload
pljones
reviewed
May 30, 2023
pljones
reviewed
May 30, 2023
pljones
reviewed
May 30, 2023
ann0see
force-pushed
the
autobuild/UseGHCommand
branch
3 times, most recently
from
b809c8c
to
7ee2ca4
Compare
pljones
reviewed
Jun 6, 2023
pljones
reviewed
Jun 7, 2023
ann0see
force-pushed
the
autobuild/UseGHCommand
branch
from
034aca3
to
29013ef
Compare
ann0see
commented
Jun 12, 2023
ann0see
force-pushed
the
autobuild/UseGHCommand
branch
from
29013ef
to
6969b9e
Compare
ann0see
force-pushed
the
autobuild/UseGHCommand
branch
from
6969b9e
to
2933063
Compare
|
I've now hard-coded the repo files. Hopefully that will work now. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ann0see
force-pushed
the
autobuild/UseGHCommand
branch
from
2933063
to
d04b092
Compare
pljones
approved these changes
Jul 13, 2023
|
I've removed the release upload and release create and delete actions now from the actions whitelist as they're no longer used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Makes more use of native gh command to get rid of third party actions. This has the benefit of less complexity and the need of trust on external dependencies.
CHANGELOG: Internal: Use native gh command for release management and uploading artefacts
Context: Fixes an issue?
Related to: #3069
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review. Tested Prerelease and release on my repo. We should decide if the current way of uploading two files on the linux build is ok or two steps/moving the whole upload logic into the autobuild scripts is preferred. This would add more complex logic.
What is missing until this pull request can be merged?
Agreement on how to handle multiple artefacts.
Checklist