Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade macOS build to macOS 14 #3297

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Jun 20, 2024

Short description of changes

CHANGELOG: Upgrade main macOS build to macOS 14 and Apple Silicon build

Context: Fixes an issue?

Fixes: #3296
Does this change need documentation? What needs to be documented and how?
No

Status of this Pull Request

Ready for testing

What is missing until this pull request can be merged?

Review and test

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see force-pushed the autobuild/macARM branch 2 times, most recently from 446a6de to d238e12 Compare June 21, 2024 19:42
* This will also build on arm runners
* Switches build directory to more standard location on Apple silicon macs
* Updates to use virtual environment for python as per https://docs.brew.sh/Python-for-Formula-Authors#python-declarations-for-applications
@ann0see ann0see requested a review from softins June 22, 2024 20:35
@ann0see
Copy link
Member Author

ann0see commented Jun 22, 2024

Still needs testing on macOS.

@ann0see
Copy link
Member Author

ann0see commented Jun 23, 2024

Ok. Client and server run on macOS. But #3287 shows up and may be even worse: I cannot register to a directory on macOS at all!

@pljones pljones added the macOS macOS runtime issue label Jun 29, 2024
@pljones pljones added this to the Release 3.12.0 milestone Jun 29, 2024
@ann0see
Copy link
Member Author

ann0see commented Jun 30, 2024

@pljones I believe this is only a minor change (even though the build architecture changed). It runs on macOS non legacy Intel as expected. The build times may decrease.

.github/autobuild/mac.sh Outdated Show resolved Hide resolved
Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
Copy link
Member

@softins softins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable and the CI build succeeds.

@ann0see ann0see merged commit cbbdb1a into jamulussoftware:main Jul 3, 2024
14 of 15 checks passed
@ann0see ann0see deleted the autobuild/macARM branch July 3, 2024 20:23
@ann0see ann0see modified the milestones: Release 3.12.0, Release 3.11.0 Jul 3, 2024
@pljones pljones added tooling Changes to the automated build system and removed macOS macOS runtime issue labels Jul 4, 2024
@softins
Copy link
Member

softins commented Jul 10, 2024

Just wanted to add a point of interest. I just tried rebasing and running a test build of mine that runs CodeQL on the main Mac build instead of on the legacy build. It would appear that CodeQL can't be enabled on the ARM runner. At least maybe not without other changes. See https://github.com/softins/jamulus/actions/runs/9874046539

@ann0see
Copy link
Member Author

ann0see commented Jul 10, 2024

I think it's not ARM but rather code signing. We moved codeql to legacy once in the past.

@softins
Copy link
Member

softins commented Jul 10, 2024

I think it's not ARM but rather code signing. We moved codeql to legacy once in the past.

CodeQL for Mac currently is on legacy, and has been for a long time. I was just experimenting with moving it back to the main build, which worked after the sudo change to the code that builds the dmg, and prior to the change to macos-14 on ARM.

The error messages on the run I linked to above suggest that the problem is with the ARM building environment, not the signing. Something to do with Rosetta.

But it's not a big problem to leave it as it is; I just thought it was good for us to be aware of the limitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Changes to the automated build system
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade main macOS runner to macOS 14 (also upgrades to Apple Silicon arm)
3 participants