Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighting isn't immediately forcing to client #15

Closed
dorpond opened this issue Sep 5, 2017 · 3 comments
Closed

Lighting isn't immediately forcing to client #15

dorpond opened this issue Sep 5, 2017 · 3 comments
Assignees
@JamzTheMan
Labels
bug fixed bug fix is committed for next release MapTool issue relates to MapTool code vs 3rd party libs
Milestone
1.4.4.0

Comments

@dorpond
Copy link

dorpond commented Sep 5, 2017 •
edited
Loading

1.4.1.7 and 1.4.3.20 (note: this problem does not exist in 1.3B91)

Simply put, when lighting is turn on or off on a token (GM side), the changes are not immediately reflected on the client side until a token is clicked.

Settings I used in test:
Start Server: Strict Token Ownership and Restricted Player Impersonation were checked. I also tried both I.View On and Off with no difference.
MT Vision: Night
FOW: On
VBL: Yes, rooms were all traced with VBL.

Steps:

  1. Drop some tokens (PC and NPC) in the room
    2 Assign a light to a PC token
  2. Expose some FOW (I did Control-I)
  3. Turn off light on the token from the GM's side
  4. Observe that the client can still see the lit up area. (Fail)
  5. Move some NPC's around and notice how the client can see them move around. (results of the fail)
  6. If a player happens to click on a token, then the lighting changes are finally pushed down and everything goes black.
  7. Conclusion: Screen should have gone black the moment the GM turned off lights - without having to click on anything on the client side.
@dorpond
Copy link
Author

dorpond commented Sep 6, 2017

This is an important bug to squish in my eyes - it has the potential of spoiling a game when players can see the DM moving stuff around, all because they didn't click on their token to get the vision updates.

@JamzTheMan JamzTheMan self-assigned this Sep 10, 2017
@JamzTheMan JamzTheMan added bug investigating researching if issue is valid and/or reasonable MapTool issue relates to MapTool code vs 3rd party libs info needed more details required from user to work this issue labels Sep 10, 2017
@JamzTheMan
Copy link
Owner

I'm going to need some more info/example/video. I just tested this with specified settings with 1.4b91, 1.4.0.5 and 1.4.4.0. Turning the light on/off on PC token was immediately pushed to client.

Attached is sample campaign saved in 1.3b91 format for testing. Let me know if I missed something?

Lighting isn't immediately forcing to client #15.zip

@JamzTheMan JamzTheMan added fixed bug fix is committed for next release and removed info needed more details required from user to work this issue investigating researching if issue is valid and/or reasonable labels Sep 17, 2017
@JamzTheMan JamzTheMan added this to the TBD milestone Sep 17, 2017
@JamzTheMan
Copy link
Owner

This should be fixed as of commit 9c82797

@JamzTheMan JamzTheMan modified the milestone: 1.4.0.0 Nov 25, 2017
JamzTheMan added a commit that referenced this issue Jun 3, 2018
@JamzTheMan
Attempt #15
f5fe9f4 
Signed-off-by: Jamz <Jamz@Nerps.net>
JamzTheMan added a commit that referenced this issue Jun 9, 2018
@JamzTheMan
MapTool 1.4.5.0
287472b 
* #49: Add proper pathfinding taking VBL into account

	- Total WIP POC

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>

* #49: Add proper pathfinding taking VBL into account

 - Cleaned up code a bit, Tweaked heuristic
 - Currently avoids any cell that has any VBL in it... to be tweaked
later

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>

* #49: Add proper pathfinding taking VBL into account

 - Buildable version...

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>

* Bug Fix

 - Preference Diaglog would error if launched from JAR or IDE as it
would be missing native libs for JVMPreferences. StartUp tab is now
disabled if not launched from native executable/missing packager lib.

Signed-off-by: Jamz <Jamz@Nerps.net>

* #49: Add proper pathfinding taking VBL into account

 - More progress on A*
 - Added Terrain Modifiers calculation and option on Token properties
 - WIP on multi threading...

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>

* Bug Fix - Inno Setup

 - Restored iss prop so directory will always populate during windows
install
 -

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>

* #49: Add proper pathfinding taking VBL into account

 - Token Properties UI changes

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>

* Enhancement - FoW optimization!

 - Changed circles to 'fake' circles (removing curves from geometry) for
faster Area.add calculations
 - WIP new "GRID" vision/light type!

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>

* #49: Add proper pathfinding taking VBL into account

 - WIP A* Pathfinding
 - WIP new "GRID" vision/light type!

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>

* com.github.jai-imageio:jai-imageio-core bumped to 1.4.0 to support Java
9

Signed-off-by: Jamz <Jamz@Nerps.net>

* Changed Sentry.IO to not log in Development envrionments.

Signed-off-by: Jamz <Jamz@Nerps.net>

* Fixes Z Order Violation

Pulled from upstream: RPTools#179

Signed-off-by: Jamz <Jamz@Nerps.net>

* Enhancement - Video Backgrounds

 * POC to add video as a background map

49: Add proper pathfinding taking VBL into account

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>

* Enhancement - #49: Add proper pathfinding taking VBL into account

 * Finished POC for ASTar Pathfinding, code cleanup
 * Spotless Applied
 * Had to remove grgit.branch.current().name for now, getting errors for
unknown reason

Signed-off-by: Jamz <Jamz@Nerps.net>

* Updated Gradle Build

 * Removed JFX-Plugin
 * Updated Spotless version to 3.13

Signed-off-by: Jamz <Jamz@Nerps.net>

* Updated for Spotless

 * Current spotless can not handle <pre> tags in comment section. Open
issue in github: diffplug/spotless#191

Signed-off-by: Jamz <Jamz@Nerps.net>

* Enhancement - Java 10!

 * Updated packaged JRE to Java 10.

Signed-off-by: Jamz <Jamz@Nerps.net>

* Update .appveyor.yml

Added Linux build

* Update .travis.yml

Removed Linux from the matrix

* Moving linux build to appveyor

 * Setting JAVA_HOME for windows only per matrix

Signed-off-by: Jamz <Jamz@Nerps.net>

* Moving linux build to appveyor

 * Setting JAVA_HOME for windows only per matrix

Signed-off-by: Jamz <Jamz@Nerps.net>

* Another appveyor test

Signed-off-by: Jamz <Jamz@Nerps.net>

* YAT

Signed-off-by: Jamz <Jamz@Nerps.net>

* YAT

Signed-off-by: Jamz <Jamz@Nerps.net>

* Update .appveyor.yml

Trigger appveyor $%$@#%#

* Appveyor not kicking off...

Signed-off-by: Jamz <Jamz@Nerps.net>

* Enhancement - AutoUpdate

 * Added tag name to Auto Update message
 * Appveyor environment var bug fix

Signed-off-by: Jamz <Jamz@Nerps.net>

* YAT

Signed-off-by: Jamz <Jamz@Nerps.net>

* YAT

Appveyor not kicking off if only yml chnaged?


Signed-off-by: Jamz <Jamz@Nerps.net>

* YAT 2

Signed-off-by: Jamz <Jamz@Nerps.net>

* WTF

Signed-off-by: Jamz <Jamz@Nerps.net>

* Attempt #12

Signed-off-by: Jamz <Jamz@Nerps.net>

* Attempt #13

Signed-off-by: Jamz <Jamz@Nerps.net>

* looking for java...

Signed-off-by: Jamz <Jamz@Nerps.net>

* Attempt #15

Signed-off-by: Jamz <Jamz@Nerps.net>

* Attempt #16

Signed-off-by: Jamz <Jamz@Nerps.net>

* Sigh... manually install jdk 10

Signed-off-by: Jamz <Jamz@Nerps.net>

* Hrm

Signed-off-by: Jamz <Jamz@Nerps.net>

* Well, can we go with java 9 then?

Signed-off-by: Jamz <Jamz@Nerps.net>

* Update .appveyor.yml

Adding manual install of Open JDK 10

* Update .appveyor.yml

Checking gradle version

* Update .appveyor.yml

change to unix gradle wrapper

* Update .appveyor.yml

Attempting to install oracle's JDK 10...

* Update .appveyor.yml

sigh...will this ever work...

* Update .appveyor.yml

one more try, why not...

* Update .appveyor.yml

Getting closer... now setting JAVA_HOME

* Update .appveyor.yml

adding fakeroot...

* Update .appveyor.yml

learn to type...

* Update .appveyor.yml

Finally working version for linux, Final tweaks...

* Update .appveyor.yml

Adding windows back.
 * Note sh: commands should only run on linux, build scripts should run on both

* Update build.gradle

Updated vendor to Nerps from Nerps-BETA.

* Update .appveyor.yml

Attempt to fix false spotless fails on windows VM

* Update .appveyor.yml

Adding init stage

* Update .appveyor.yml

added tag: $(APPVEYOR_REPO_TAG_NAME)

* Update .appveyor.yml

Test if linux/windows order matters

* Update .appveyor.yml

Uppercased APPVEYOR_REPO_TAG for Linux

* Enhancement #68 - Changing Language

 * Added JVM User Option to change default MapTool language via Edit ->
Preferences -> Startup tab
 * Moved MAPTOOL_DATADIR from JvmOptions to userJvmOptions and enabled
user setting in Edit -> Preferences -> Startup tab

Signed-off-by: Jamz <Jamz@Nerps.net>

* #49: Add proper pathfinding taking VBL into account

 * Pathfinding now properly works for Hex grid!
 * Refactored and cleaned up code for AStar Pathfinding

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>

* #63 Restore default behavior of spacebar+left mouse click

 * Spacebar functionality has been restored to it's original behavior
including ctrl+spacebar & shift+spacebar as well.
 * A new shift+ctrl+spacebar command along with a new pointer image is
now available. When this keystroke combo is pressed, and you are a GM,
the pointer will center & zoom all connected clients to that point. When
it is released, all clients will return to their previous view point &
zoom.

Task-Url: #63

Signed-off-by: Jamz <Jamz@Nerps.net>

* Spotless...

Signed-off-by: Jamz <Jamz@Nerps.net>

* #67: New Vision/Light type: GRID

 * Clear gridShapeCache on grid change
 * Instatiante footprint field to prevent null pointer on measuring
tool.

Task-Url: #67

Signed-off-by: Jamz <Jamz@Nerps.net>

* #49: Add proper pathfinding taking VBL into account

 * When token movement is done (left click released) we now wait for the
final background thread for A* Pathfinding is to either finish or time
out so quick or long moves get a chance to render a path.

Task-Url: #49

Signed-off-by: Jamz <Jamz@Nerps.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamzTheMan JamzTheMan

Labels
bug fixed bug fix is committed for next release MapTool issue relates to MapTool code vs 3rd party libs
Projects
None yet
Milestone
1.4.4.0
Development

No branches or pull requests
2 participants
@JamzTheMan @dorpond