Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cucumber): Support callback style step definitions (fixes #8) #10

Merged
merged 1 commit into from
Dec 6, 2016
Merged

fix(cucumber): Support callback style step definitions (fixes #8) #10

merged 1 commit into from
Dec 6, 2016

Conversation

InvictusMB
Copy link
Contributor

Match syncronized steps with the contract cucumber expects. es6 generators accepted by cucumber are still not supported (#9)

fix(cucumber): Support callback style step definitions (fixes serenit…
4278968 
…y-js#8)

Match syncronized steps with the contract cucumber expects. es6 generators accepted by cucumber are still not supported (serenity-js#9)
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 97.4% when pulling 4278968 on InvictusMB:master into f3d7198 on jan-molak:master.

@jan-molak
Copy link
Member

Hey @InvictusMB and thanks for your contribution! I'll review the PR shortly.

@jan-molak jan-molak merged commit 4278968 into serenity-js:master Dec 6, 2016
@jan-molak
Copy link
Member

Looks good to me, thanks for your help! 👍

jan-molak added a commit that referenced this pull request Dec 6, 2016
@jan-molak
fix(dependencies): Updated the shrinkwrap so that the new deps are in…
31fbd22 
…cluded

Adding new dependencies, such as is-generator in #10, requires generating a new npm-shrinkwrap.json

file as npm-shrinkwrap.json takes precendence over package.json

#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@InvictusMB @coveralls @jan-molak