#160 feat: add WaitForQuestion to ActiveWait

[nbarrett]

Hey @jan-molak I've added WaitForQuestion in order to provide further waiting flexibility outside of waiting for an ElementFinder Condition to be met (which as I understand is focussed on a the state of a single element). In my project I found myself wanting to wait for more sophisticated conditions that lean on the parsing/transformation/aggregation that can only really be done in a Question.

So this pull request now allows you to do this kind of thing:
Wait.upTo(<duration>).untilQuestionAnsweredTrue(<boolean Promise returning Question>)

[jan-molak]

Thanks @nbarrett! I've decided to re-write the Wait interaction completely to address this use case.
In Serenity/JS 2.0 you will be able to do things like:

import { Text, Website } from '@serenity-js/protractor';
import { endsWith, Ensure, equals } from '@serenity-js/assertions';

const Header = Target.the('header').located(by.css('h1'));

actor.attemptsTo(
  Wait.until(Header, isVisible()),
  Wait.until(Text.of(Header), equals('Hello Nick!')),
  Wait.until(Website.url(), endsWith(Text.of(Header))),
  Ensure.that(Website.url(), endsWith(Text.of(Header))),
);

Stay tuned :-)

[nbarrett]

Hey @jan-molak - looking at your examples above, I'm not sure whether your solution will address my requirement as that seems to focus on examining the state of single element. However my requirement stemmed from the need to wait for more sophisticated conditions (parsing/transformation/aggregation) that can only be achieved in a Question

[jan-molak]

OK, let me re-open it for the time being and add the link to the code sample we discussed.

[nbarrett]

Cheers @jan-molak! Actually that code is kinda in this PR too!

[nbarrett]

Hey @jan-molak - I closed this PR as I realised this functionality is now in Serenity 2.0 and I've replaced the code in my old solution with the new code. Awesome job!!