Fix record live tv show [PVR API 1.9.7 regression]

[metaron-uk]

Based on problem reported on the forum
http://forum.kodi.tv/showthread.php?tid=280430&pid=2364805#pid2364805

Tested against my 0.27 system (schedules direct guide data, UK) and seems to work.

1. recording of currently in progress live TV until end of current show - works
2. recording of a show in the future on the same channel via the fullscreen video EPG - works

Not tested: 0.28 backend, recording live TV without any guide data.

[metaron-uk]

Slightly modified to fix starting a recording of a channel which doesn't have valid EPG data. (You get the default recording duration)

[janbar]

Thanks Andrew. Seems ok. I will merge it in tomorrow.

[janbar]

Is strictly less than program->endTime more suitable ?
i.e timer.startTime < program->endTime

[metaron-uk]

Short answer: maybe end would work as well, but I haven't tested it. Long answer: You can submit timers from within live tv playback for shows in progress or in the future. If the current programme being watched matches the selected timer, then we need to convert live tv to an instant recording. If the selected programme starts after the current live show, then it must be in the future, so we need a new recording rule. If the timer has 0 start time, there isn't an epg entry and we need to assume convert live to recording (current code behaviour). Maybe it also has zero end time, but I didn't check. You can group these two conditions using <=. The case this doesn't cover is a repeating timer (which could be this programme, a later one or an earlier one), but I didn't see how to request one from within the confluence ui while watching live tv and the original code didn't seem to cover this possibility anyway. Maybe I could look to deal with the repeating timer possibility in a selarate pr? Sent with AquaMail for Android http://www.aqua-mail.com

[metaron-uk]

Actually no it won't the way you suggest. We need a 100% epg match, or the
user won't get what they expect.
Andrew

Sent with AquaMail for Android
http://www.aqua-mail.com

On June 30, 2016 5:17:47 PM Jean-Luc Barrière notifications@github.com wrote:

{
Myth::ProgramPtr program = m_liveStream->GetPlayedProgram();

• if (timer.iClientChannelUid ==
  FindPVRChannelUid(program->channel.chanId))
• if (timer.iClientChannelUid ==
  FindPVRChannelUid(program->channel.chanId) &&

•    timer.startTime <= program->startTime)
  

Is endTime more suitable ?

---

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/janbar/pvr.mythtv/pull/39/files/0c71e0f8e71ace31656d19b9174ec374241dcab1#r69163441

[janbar]

Okay. I will test it this week-end. Thanks Andrew.

[janbar]

Okay I anderstood the need: You want keep liveTV recording when pressing "record" of the current show in the EPG screen. +1