[BUGFIX] Added missing checkbox fields, added missing query parameters #2
Conversation
| { in: 'query', name: 'locale', schema: { type: 'string' } }, | ||
| { in: 'query', name: 'fallback-locale', schema: { type: 'string' } }, |
There was a problem hiding this comment.
I believe that available locales could (and eventually should) be extracted from the Payload config. Then, we could expose them as {type: 'string', enum: ['en', ...]}. If you just need a quick patch now, please make an issue to track this. Or just a code TODO.
There was a problem hiding this comment.
Good idea. I have a local setup for my project right now, so there's no hurry to release on NPM.
There was a problem hiding this comment.
I believe the chmod change is not intentional?
There was a problem hiding this comment.
Definitely not. I usually set git to ignore file modes. I will set it back to 644.
Originally, I started it because there was no open source headless CMS with good OpenAPI support and PayloadCMS seemed like a cool project with a lot of momentum (well, it is exactly that). I want to use the package for a couple of website projects, which will probably make me work on this package further. That will probably happen in two or three weeks, but no promises. In general, my plans are outlined in the roadmap in the readme file. I understand it's very brief though. If you have some ideas or requests, feel free to open issues 🙂
Not pushy at all! I appreciate the help 🙂 |
Agreed, and your version outputs the cleanest so far. Not much bloat, readable names, yay.
I think the current code base needs some clean-up and restructuring to make further development easier.
I'd be happy to code a suggestion if you're available for reviews. |
I'm excited to hear that!
Sure!
Yeah, the transition from proof-of-concept to a maintainable package is not 100% yet.
I usually just run Also, there is now https://github.com/payloadcms/eslint-config - it may be worth it to use it. |
|
Hi again, I'm unsure when or how I'll have the time to work more on this. I would submit another PR anyway. Can we merge and release this one? |
Hi, done, merged, released. I may have some time to work on the plugin next weekend. If it actually happens, I'll take care of that enum as well. |
Hi again,
This PR contains a change to add
checkboxfields as booleans to the schema.I've also added the base REST query parameters, as described in the payload documentation.
May I ask what your plans are for this repository?
I'm trying to gauge how much effort I should put into the current code base vs. writing or refactoring my own, if anything else comes up.
If you prefer discussing this separately from this PR, feel free to add me on Discord
barthy.koeln#2946.Sorry if I seem pushy, I'm just working on a Payload + Astro project right now :)
Barthy