Skip to content

Commit

Permalink
Exclude execution fence from memory fence
Browse files Browse the repository at this point in the history
  • Loading branch information
janciesko committed May 6, 2024
1 parent 645b2f9 commit eb5acd5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 12 deletions.
5 changes: 1 addition & 4 deletions src/impl/nvshmemspace/Kokkos_NVSHMEMSpace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,7 @@ void NVSHMEMSpace::impl_deallocate(
}
}

void NVSHMEMSpace::fence() {
Kokkos::fence();
nvshmem_barrier_all();
}
void NVSHMEMSpace::fence() { nvshmem_barrier_all(); }

KOKKOS_FUNCTION
int get_num_pes() { return nvshmem_n_pes(); }
Expand Down
5 changes: 1 addition & 4 deletions src/impl/rocshmemspace/Kokkos_ROCSHMEMSpace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,7 @@ void ROCSHMEMSpace::impl_deallocate(
}
}

void ROCSHMEMSpace::fence() {
Kokkos::fence();
roc_shmem_barrier_all();
}
void ROCSHMEMSpace::fence() { roc_shmem_barrier_all(); }

KOKKOS_FUNCTION
size_t get_num_pes() { return roc_shmem_n_pes(); }
Expand Down
5 changes: 1 addition & 4 deletions src/impl/shmemspace/Kokkos_SHMEMSpace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,7 @@ void SHMEMSpace::impl_deallocate(
}
}

void SHMEMSpace::fence() {
Kokkos::fence();
shmem_barrier_all();
}
void SHMEMSpace::fence() { shmem_barrier_all(); }

size_t get_num_pes() { return shmem_n_pes(); }
size_t get_my_pe() { return shmem_my_pe(); }
Expand Down

0 comments on commit eb5acd5

Please sign in to comment.