Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudinary #18

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Cloudinary #18

merged 2 commits into from
Aug 13, 2018

Conversation

janczizikow
Copy link
Owner

Adding Cloudinary images :
✅ Adding gems
✅ Generating Photo uploader class

@@ -63,6 +71,8 @@ GEM
railties (>= 4.1.0, < 6.0)
responders
warden (~> 1.2.3)
domain_name (0.5.20180417)
unf (>= 0.0.5, < 1.0.0)
dotenv (2.5.0)
dotenv-rails (2.5.0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify this as: gem 'dotenv-rails', groups: [:development, :test] ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure let's do it

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait, actually it's already group there:
screen shot 2018-08-13 at 6 52 41 pm

@nguyehi1 nguyehi1 merged commit e354d7e into master Aug 13, 2018
@janczizikow janczizikow deleted the cloudinary branch August 13, 2018 16:53
@janczizikow janczizikow mentioned this pull request Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants