Core python3 support #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete module, disable test it is not used anywhere
python3 deprecates __nonzero__ and introduces __bool__ This commit introduces __bool__ while maintaining python2 compatibility
Also, remove the __div__ and __rdiv__ magic methods
In python 2, None >= 0 returns false. However, in py3, None cannot be compared with zero. This commit ensures identical behaviour in py2,3 when min is none.
fixes jandecaluwe#23
|
Fantastic work and a joy to review and learn from - thx! |
|
+1, amazing work @jck! Thanks for all the contributions. |
|
I can't take all the credit. @jmgc and the excellent test suite made this process simple :) Python 3 support for conversion and cosimulation is coming very soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes MyHDL's core compatible with python3.