Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase segment does not work on child folders #4850

Closed
1 task done
QuentinPhrl opened this issue Apr 18, 2024 · 2 comments
Closed
1 task done

Firebase segment does not work on child folders #4850

QuentinPhrl opened this issue Apr 18, 2024 · 2 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@QuentinPhrl
Copy link

Code of Conduct

  • I agree to follow this project's Code of Conduct

What happened?

Issue

The new Firebase segment proposed by @ivan-the-terrible only works at the root of a Firebase project.

Here's an example in a firebase function project

Prompt

Solution

As in the script I made to provide a solution before the official segment was created, all you need is the go equivalent of a startwith on the current prompt path

https://github.com/QuentinPhrl/Omp_firebase_prompt/blob/6b6705349a0aeaccd2aaaef342bdb9e19ba27b4a/src/.firebase_project.zsh

Theme

cloud-native-azure

What OS are you seeing the problem on?

macOS

Which shell are you using?

zsh

Log output

N/A
@QuentinPhrl QuentinPhrl added the 🐛 bug Something isn't working label Apr 18, 2024
@ivan-the-terrible
Copy link
Contributor

Working on a patch as we speak! It's as easy as || strings.HasPrefix(key, f.env.Pwd()).

I'll get the code out and a proper test case for this asap!

@ivan-the-terrible
Copy link
Contributor

#4852
Fix has been raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants