Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: general Fade(from, to, duration) method #106

Merged
merged 6 commits into from
Nov 16, 2022
Merged

add: general Fade(from, to, duration) method #106

merged 6 commits into from
Nov 16, 2022

Conversation

jandelgado
Copy link
Owner

@jandelgado jandelgado commented Nov 13, 2022 •
edited

See #66

@jandelgado
FadeOn/FadeOff now use generalized Breathe evaluator
736338d 
allowing us to get rid of classes formerly used for FadeOn/FadeOff
@coveralls
Copy link

coveralls commented Nov 13, 2022 •
edited

Coverage Status

Coverage increased (+1.3%) to 96.517% when pulling 63a83c0 on add_fade_from_to into 7bf7edc on master.

@jandelgado
add generalized Fade(from,to,duration) function
3e4a9d1 
which internally configures the breathe-effect with min- and
max-brightness correctly set up.
@jandelgado jandelgado marked this pull request as ready for review November 13, 2022 20:59
@jandelgado jandelgado force-pushed the add_fade_from_to branch 2 times, most recently from e75383d to b1bde85 Compare November 16, 2022 20:09
@jandelgado jandelgado merged commit 4f8de1f into master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jandelgado @coveralls