Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support a11y with list & listitem #67

Merged
merged 2 commits into from
Feb 24, 2020
Merged

support a11y with list & listitem #67

merged 2 commits into from
Feb 24, 2020

Conversation

jhelst
Copy link
Contributor

@jhelst jhelst commented Feb 24, 2020 •
edited

Change Type

  • Feature
  • Chore
  • Bug Fix

Change Level

  • major
  • minor
  • patch

Further Information (screenshots, etc)

This allows screen readers to read the number of items in the whirligig as if it were a <ul> with <li>s as children.

Relevant Links (bug reports, etc)

Checklist

  • Added tests / did not decrease code coverage
  • Tested across browsers

@jhelst jhelst requested a review from a team February 24, 2020 17:33
@codeclimate
Copy link

codeclimate bot commented Feb 24, 2020 •
edited

Code Climate has analyzed commit bbb72a4 and detected 0 issues on this pull request.

View more on Code Climate.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.634% when pulling bbb72a4 on feature/a11y-list into f71fcde on master.

@jhelst jhelst merged commit f05eba2 into master Feb 24, 2020
@jhelst jhelst deleted the feature/a11y-list branch February 24, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacanger zacanger zacanger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhelst @coveralls @zacanger