Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAT 1382 Fetch patient info through room status api #165

Merged
merged 10 commits into from
Nov 9, 2023

Conversation

bitghost2m
Copy link

@bitghost2m bitghost2m commented Nov 8, 2023

Description

This PR updates the existing jwt workflow for jitsi webapp so the patient info is fetched through the room status api.

Release Risk Assessment

Medium Risk

Demo Notes

QA and Smoke Testing

Require sanity test on local and sandbox.

Steps to Reproduce

  1. book an appointment and start a session
  2. The staff can see treatment info and patient name in the waiting room
  3. patient can also so the name in the avatar
  4. sanity test on the major features.

Fixed / Expected Behaviour

Other Considerations

  • Will this affect other parts of the app or views?
    only on webapp
  • How can the success of this work be confirmed after release to production?
    need a smoke test on production once it's deployed to the UK pod
  • What QA have you already done?
    local test and will perform another test on the sandbox env

Screenshots

Before

After

@bitghost2m bitghost2m added the Risk - Med Medium risk of disruption to codebase or infrastructure. label Nov 8, 2023
@bitghost2m bitghost2m self-assigned this Nov 8, 2023
Copy link

@ivanjiang5628 ivanjiang5628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bitghost2m
Copy link
Author

bitghost2m commented Nov 8, 2023

Just a note, we need to QA this change with

  1. Jane master branch on sandbox
  2. changes in master branch with the patient info removed from JWT

Copy link

@kaeramirez kaeramirez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on this @bitghost2m. Thank you for tweaking setJaneAppointmentDetails action it was good for me to see how that could have been improved 👍

@bitghost2m bitghost2m merged commit 8ef91d4 into master Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Risk - Med Medium risk of disruption to codebase or infrastructure.
Projects
None yet
3 participants