Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable SentryWebpackPlugin only if SENTRY_AUTH_TOKEN is set #168

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enable SentryWebpackPlugin only if SENTRY_AUTH_TOKEN is set #168

wants to merge 2 commits into from

Conversation

ivanjiang5628
Copy link

@ivanjiang5628 ivanjiang5628 commented Nov 23, 2023 •
edited

Description

  • This PR updates our Webpack configuration to include sentryWebpackPlugin only when the SENTRY_AUTH_TOKEN env variable is properly set.

Release Risk Assessment

Almost zero as it only touches the sentry integration.

Demo Notes

QA and Smoke Testing

Steps to Reproduce

Smoke test

Fixed / Expected Behaviour

Other Considerations

  • Will this affect other parts of the app or views?
  • How can the success of this work be confirmed after release to production?
  • What QA have you already done?

Screenshots

Before

After

@ivanjiang5628 ivanjiang5628 self-assigned this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitghost2m bitghost2m bitghost2m approved these changes

@kaeramirez kaeramirez kaeramirez approved these changes

Assignees

@ivanjiang5628 ivanjiang5628

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ivanjiang5628 @bitghost2m @kaeramirez