Export CJS and MJS packages from the same build #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 99.89% 99.89%
=======================================
Files 45 45
Lines 970 970
Branches 109 109
=======================================
Hits 969 969
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
When using the parent index file to import a sibling file the CJS loader fails to resolve the class before it's needed by the implementation or extending classes. This does not affect ES modules.
angelaraya
force-pushed
the
dual-cjs-mjs-exports
branch
from
60c8a11
to
ff9916c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content looks good and consistent, however I'm not setting the desired effect on the service implementation. Will hold off this while resolving what's going on in there.
@elf-pavlik I'd appreciate if you can double check this in the mean time.