Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait on got v12 for potential fix to timeouts not being respected #698

Closed
JaneJeon opened this issue Jan 2, 2022 · 0 comments
Closed

Wait on got v12 for potential fix to timeouts not being respected #698

JaneJeon opened this issue Jan 2, 2022 · 0 comments
Labels
blocked Can't do this right now

Comments

@JaneJeon
Copy link
Owner

JaneJeon commented Jan 2, 2022

Blocked on #604

There's currently a bug with got v11 (the last CJS version) where requests with hosts that can't be found - in time - doesn't actually get timed out as set by the timeout option.

Apparently, the bug is fixed in v12: sindresorhus/got#1899

So I need to re-enable the "rejects valid but nonexistent URLs" test.
@JaneJeon JaneJeon added the blocked Can't do this right now label Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Can't do this right now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JaneJeon