Reduce memory usage and speed up computation #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the peak memory footprint by 20%: - before: ``` In [13]: h = agglo.Rag(ws, p1, feature_manager=tf.f4) In [13] used 104.9492 MiB RAM in 29.23s, peaked 62.71 MiB above current, total RAM usage 447.95 MiB ``` - after: ``` In [18]: k = agglo.Rag(ws, p1, feature_manager=tf.f4) In [18] used 109.6367 MiB RAM in 29.08s, peaked 28.79 MiB above current, total RAM usage 559.28 MiB ```
The progress bar can still be enabled, but the idxs sequence is not wrapped in a null-object when it's not needed. This speeds things up by about 10%.
jni
added a commit
that referenced
this pull request
Jul 10, 2015
Reduce memory usage and speed up computation
|
way to go juan! |
|
@NealJMD 👍 Thanks! =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RAG memory footprint is down ~40%
RAG build time is down ~70%