-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalizers should be cacheable with CacheableSupportsMethodInterface #54
Normalizers should be cacheable with CacheableSupportsMethodInterface #54
Conversation
make all the generated Normalizers cacheable with CacheableSupportsMethodInterface
0e35346
to
5b46f41
Compare
All ready to merge 🎉
|
Why doing an option for cacheable support ? It should be always enable imo, no need for an option here. And if we must support old versions of serializer, then this interface should be implemented only if it exist |
After quick talk with @joelwurtz & @bastnic we decided to keep the option but default value would be |
5b06fed
to
7330cc9
Compare
7330cc9
to
7c207f8
Compare
Co-Authored-By: Korbeil <baptiste.leduc@gmail.com>
Second hand on #52
Fixed some stuff that wasn't working.