fix: prefix property starting with number with 'n' #584

[Gounlaf]

No description provided.

[Gounlaf]

@Korbeil could you please explain me how you re-generate all data for tests?
The process is not quite clear for me =/

[Korbeil]

@Korbeil could you please explain me how you re-generate all data for tests? The process is not quite clear for me =/

Hey @Gounlaf, sure !
First thing: run the tests, it will fill all the "generated" folders, once that's done and if you added a new fixture test, you have to run the .replace-all-expected-fixtures.sh script on this repository root to replace all expected folders with their respective generated folder.

[Gounlaf]

@Korbeil it should be OK now

[Korbeil]

Getters & setters should still be get1() and set1()

[Gounlaf]

I face this problem:

• getName() can't be used because it the original name of the property; one the side effect is, for property like "+1" and "-1" (in the github dataset), it's cleaned as "1"; it generate two getters/setters with the same name
• using getPhpName, it contains the prefix.
• I put the prefix with "n" in the Naming class to avoid do it in many places...

What should I do?

• doesn't apply the cleaning in getPropertyName? it will not be stored in and returned by getPhpName
• or maybe add a new property on the Property class?

[Korbeil]

I think it's worth having a new property on Property class, one for properties and one for methods :)

[Gounlaf]

Roger 👌

[Gounlaf]

I had to make Naming::cleaning() public.

[Korbeil]

Thanks a lot for your contribution, could you add a note about it in the CHANGELOG file pls ?

[Gounlaf]

Thanks a lot for your contribution, could you add a note about it in the CHANGELOG file pls ?

Yes.
And I will squash if it's OK for you.

[Korbeil]

Thanks again for this contribution !