Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oneOf with nullable #595

Merged
merged 1 commit into from Feb 14, 2022
Merged

fix: oneOf with nullable #595

merged 1 commit into from Feb 14, 2022

Conversation

Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented Feb 3, 2022

It should fix #352

@Gounlaf
Copy link
Contributor Author

Gounlaf commented Feb 3, 2022

I'm not sure if it works for OpenApi2 and OpenApi3

@Korbeil
Copy link
Member

Korbeil commented Feb 14, 2022

I'm not sure if it works for OpenApi2 and OpenApi3

I think it should be fine :)

@Korbeil
Copy link
Member

Korbeil commented Feb 14, 2022

Could you add something in the CHANGELOG file pls ? @Gounlaf

@Gounlaf
Copy link
Contributor Author

Gounlaf commented Feb 14, 2022

Done and squashed

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Florian Levis <levis.florian@gmail.com>
Signed-off-by: Florian Levis <florian.levis@alphanetworks.tv>
@Korbeil Korbeil merged commit 317f87b into janephp:next Feb 14, 2022
@Korbeil
Copy link
Member

Korbeil commented Feb 14, 2022

Thanks for your contribution ! @Gounlaf

@Korbeil Korbeil mentioned this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JsonSchema] Property nullable or reference an object
2 participants