Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nullable properties #84

Merged
merged 1 commit into from
Jun 17, 2019
Merged

nullable properties #84

merged 1 commit into from
Jun 17, 2019

Conversation

serl
Copy link
Contributor

@serl serl commented Jun 12, 2019

This should address #73.

Anyway, we should first talk about this, as I'm not really sure of what I'm doing here.
The meat is in the first commit. Does it look good?
Then I updated the tests that broke other tests. I ended up setting the Json Schema test as non-strict (last commit). This makes all tests pass, but maybe we shouldn't have that disabled..? Also, this is going to break users' code...

@Korbeil
Copy link
Member

Korbeil commented Jun 12, 2019

Could you rebase onto master ? Just to avoid having old commit here.

@serl serl marked this pull request as ready for review June 12, 2019 12:03
@coveralls
Copy link

coveralls commented Jun 12, 2019

Pull Request Test Coverage Report for Build 392

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 86.289%

Totals Coverage Status
Change from base Build 387: 0.03%
Covered Lines: 2983
Relevant Lines: 3457

💛 - Coveralls

@serl
Copy link
Contributor Author

serl commented Jun 12, 2019

Done!
(I'll take care about the squashing at the end)

@Korbeil
Copy link
Member

Korbeil commented Jun 12, 2019

Could you squash pls ?
And if you have time to make same patch for 4.x branch that would be awesome (if not I can handle that 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants