Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port discriminator feature from 4.x branch to master #91

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Port discriminator feature from 4.x branch to master #91

merged 1 commit into from
Jun 19, 2019

Conversation

Korbeil
Copy link
Member

@Korbeil Korbeil commented Jun 19, 2019

Same as #60 but for master branch
I'm actually following 4.x implementation but will include oneOf mechanic later

@coveralls
Copy link

Pull Request Test Coverage Report for Build 406

  • 135 of 138 (97.83%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 86.702%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/OpenApi/Generator/Model/ClassGenerator.php 8 9 88.89%
src/OpenApi/Guesser/Guess/MultipleClass.php 11 13 84.62%
Totals Coverage Status
Change from base Build 401: 0.4%
Covered Lines: 3097
Relevant Lines: 3572
💛 - Coveralls

@Korbeil Korbeil merged commit a4e67df into janephp:master Jun 19, 2019
@Korbeil Korbeil deleted the feature/discriminator-implementation branch June 19, 2019 10:15
@Korbeil Korbeil mentioned this pull request Jun 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Korbeil @coveralls